Add a new snow thermal conductivity calculation to ELM #6524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trhille please review. |
bishtgautam
reviewed
Aug 15, 2024
Comment on lines
958
to
966
| k_snw_vals(i) = 2.564 * (bw(c,j)/ rho_ice)**2 - 0.059 * (bw(c,j)/ rho_ice) + 0.0205 | ||
| else if (i == 2) then | ||
| k_snw_vals(i) = 2.172 * (bw(c,j)/ rho_ice)**2 + 0.015 * (bw(c,j)/ rho_ice) + 0.0252 | ||
| else if (i == 3) then | ||
| k_snw_vals(i) = 1.985 * (bw(c,j)/ rho_ice)**2 + 0.073 * (bw(c,j)/ rho_ice) + 0.0336 | ||
| else if (i == 4) then | ||
| k_snw_vals(i) = 1.883 * (bw(c,j)/ rho_ice)**2 + 0.107 * (bw(c,j)/ rho_ice) + 0.0386 | ||
| else if (i == 5) then | ||
| k_snw_vals(i) = 1.776 * (bw(c,j)/ rho_ice)**2 + 0.147 * (bw(c,j)/ rho_ice) + 0.0455 |
There was a problem hiding this comment.
Could you please add _r8 to constants e.g. 2.564_r8 * (bw(c,j)/ rho_ice)**2 - 0.059_r8 * (bw(c,j)/ rho_ice) + 0.0205_r8?
bishtgautam
reviewed
Aug 15, 2024
| real(r8), parameter :: rho_ice = 917._r8 | ||
| real(r8) :: k_snw_vals(5) | ||
| real(r8) :: k_snw_tmps(5) | ||
| data k_snw_tmps(:) /223.0, 248.0, 263.0, 268.0, 273.0/ |
There was a problem hiding this comment.
Please also add _r8 here.
trhille
requested changes
Aug 15, 2024
| end if | ||
| do i = 1, size(k_snw_tmps) - 1 | ||
| if (k_snw_tmps(i) <= t_soisno(c,j) .and. t_soisno(c,j) <= k_snw_tmps(i + 1)) then | ||
| thk(c,j) = k_snw_vals(i) + (t_soisno(c,j) - k_snw_tmps(i))*(k_snw_vals(i + 1)-k_snw_vals(i))/(k_snw_tmps(i + 1)-k_snw_tmps(i)) |
There was a problem hiding this comment.
I don't know if there are ELM conventions that I'm unaware of, but in general it's much easier to read code with consistent use of spaces (or no spaces) around operators.
| ! Only examine levels from snl(c)+1 -> 0 where snl(c) < 1 | ||
| if (snl(c)+1 < 1 .AND. (j >= snl(c)+1) .AND. (j <= 0)) then | ||
| bw(c,j) = (h2osoi_ice(c,j)+h2osoi_liq(c,j))/(frac_sno(c)*dz(c,j)) | ||
| thk(c,j) = tkair + (7.75e-5_r8 *bw(c,j) + 1.105e-6_r8*bw(c,j)*bw(c,j))*(tkice-tkair) |
There was a problem hiding this comment.
Same comment as above regarding consistent use of spaces.
There was a problem hiding this comment.
Please space consistently here too.
| @@ -943,14 +948,49 @@ subroutine SoilThermProp (bounds, num_nolakec, filter_nolakec, & | |||
| endif | |||
| endif | |||
| endif | |||
|
|
|||
| if (use_T_rho_dependent_snowthk) then ! chose which snow thermal conductivity to use | |||
There was a problem hiding this comment.
Suggested change
| if (use_T_rho_dependent_snowthk) then ! chose which snow thermal conductivity to use | |
| if (use_T_rho_dependent_snowthk) then ! choose which snow thermal conductivity to use |
There was a problem hiding this comment.
Thanks for the feedback, I made the changes and rebased with master.
based on Fourteau, et al. (2021) - is now density and temp dependent
chloewhicker
force-pushed
the
cwhicker/elm/use_use_T_rho_dependent_snowthk_20240719
branch
from
c02efdf to
a4e9c06
Compare
trhille
requested changes
Aug 20, 2024
There was a problem hiding this comment.
@chloewhicker, thanks for addressing those. Two more tiny changes and then I'm happy to approve.
| ! Only examine levels from snl(c)+1 -> 0 where snl(c) < 1 | ||
| if (snl(c)+1 < 1 .AND. (j >= snl(c)+1) .AND. (j <= 0)) then | ||
| bw(c,j) = (h2osoi_ice(c,j)+h2osoi_liq(c,j))/(frac_sno(c)*dz(c,j)) | ||
| thk(c,j) = tkair + (7.75e-5_r8 *bw(c,j) + 1.105e-6_r8*bw(c,j)*bw(c,j))*(tkice-tkair) |
There was a problem hiding this comment.
Please space consistently here too.
trhille
approved these changes
Aug 20, 2024
bishtgautam
approved these changes
Aug 20, 2024
bishtgautam
added a commit
that referenced
this pull request
Aug 20, 2024
…into next (PR #6524) Implemented the new snow thermal conductivity calculation method introduced in [Fourteau, et al. (2021)](https://tc.copernicus.org/articles/15/2739/2021/) in ELM. This improves the current method, introduced in [Jordan (1991)](https://erdc-library.erdc.dren.mil/jspui/handle/11681/11677) which only depends on the snow density. relevant nl changes `use_T_rho_dependent_snowthk = .true. ` [ELM] [BFB] [NML]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented the new snow thermal conductivity calculation method introduced in Fourteau, et al. (2021) in ELM. This improves the current method, introduced in Jordan (1991) which only depends on the snow density.
More information can be found here: https://acme-climate.atlassian.net/wiki/spaces/FAN/pages/4391501825/Snow+Temperature+and+Density+Dependent+Thermal+Conductivity
relevant nl changes
use_T_rho_dependent_snowthk = .true.[ELM]
[BFB]
[NML]