Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade e3sm-imgs to 0.0.9 and add singularity2 machine #6519

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

mahf708
Copy link
Contributor

@mahf708 mahf708 commented Jul 21, 2024

A significant update in the underlying container image we are using for the "gh" testing suite. These updates primarily include moving to a spack-based installation/building of key tools. The container is now based on ubuntu 22.04 (apr 2022) with gcc 11 (the default gcc compilers for ubuntu 22.04). This update is the first step towards operationalizing these containers (with different varieties, e.g., oneapi compilers, etc.) for production-grade runs.

Relevant changes in container repo: mahf708/e3sm-imgs@v0.0.6...v0.0.9

@mahf708 mahf708 added the Testing Anything related to unit/system tests label Jul 21, 2024
Copy link

github-actions bot commented Jul 21, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6519/
on branch gh-pages at 2024-07-22 03:22 UTC

@mahf708 mahf708 marked this pull request as draft July 21, 2024 21:15
@mahf708 mahf708 changed the title upgrade e3sm-imgs to 0.0.7 and add singularity2 machine upgrade e3sm-imgs to 0.0.9 and add singularity2 machine Jul 22, 2024
@mahf708 mahf708 force-pushed the mahf708/idp/e3sm-imgs-v0.0.7 branch from 00bb9a1 to 767332e Compare July 22, 2024 02:14
@mahf708 mahf708 requested review from rljacob, ndkeen and jgfouca July 22, 2024 15:46
@mahf708 mahf708 marked this pull request as ready for review July 22, 2024 15:46
@rljacob rljacob self-assigned this Jul 23, 2024
container:
image: ghcr.io/mahf708/e3sm-imgs:v0.0.6
image: ghcr.io/mahf708/e3sm-imgs:v0.0.9
Copy link
Member

@rljacob rljacob Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move these images to an E3SM account?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

I was planning of moving the entire "e3sm-imgs" repo (or we can rename it) to E3SM-Project once we cross the 0.1.0 version threshold. There's only substantial one item on my todo list before reaching the 0.1.0: making an intel container (cpu). There's also one logistical point I would like to address (saving less of the intermediate "test"-tagged containers, which I could do in one PR soon).

Do you prefer I address these two items before integrating this PR or in a subsequent PR?

Alternatively, I can also upload these images directly to the E3SM Docker account from my repo, though I think we should have the repo be under E3SM-Project sooner or later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can wait.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other thing you will notice is that I opted to introduce "singularity2" temporarily because I didn't want to mess up the circleci workflow (I will reunite the two singularities soon, but I am trying to focus on getting the intel container as well as some basic runtime/production container going...)

rljacob added a commit that referenced this pull request Jul 26, 2024
A significant update in the underlying container image we are using for the "gh" testing suite.
These updates primarily include moving to a spack-based installation/building of key tools.
The container is now based on ubuntu 22.04 (apr 2022) with gcc 11 (the default gcc compilers for ubuntu 22.04).
This update is the first step towards operationalizing these containers
(with different varieties, e.g., oneapi compilers, etc.) for production-grade runs.

Relevant changes in container repo: mahf708/[email protected]

[BFB]
@rljacob rljacob added the BFB PR leaves answers BFB label Jul 26, 2024
@rljacob rljacob merged commit 466fa81 into master Jul 26, 2024
21 checks passed
@rljacob rljacob deleted the mahf708/idp/e3sm-imgs-v0.0.7 branch July 26, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB Testing Anything related to unit/system tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants