Fix performance tests on anvil and pm-cpu #6431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amametjanov
added
Anvil
Testing
|
amametjanov
added a commit
that referenced
this pull request
May 18, 2024
Fix performance tests on anvil and pm-cpu: - fix SGLC regex patterns to revert to correct perf-test PEs on Anvil - avoid memleak flags in heavy-IO perf-tests on pm-cpu [BFB]
|
I was wondering how that incorrect regex pattern made it into the repo with recent PR -- but why do we even need SGLC string? Is it trying to differentiate between other compsets that don't use SGLC? If not, seems like we can just remove it (ie back to the way it was) |
|
Yes, I think it was added to differentiate between stub SGLC and active MALI components: e.g. |
|
OK that's fine if it was done to differentiate between res/compsets. I'm now waiting on this PR to make some unrelated changes. |
ndkeen
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix performance tests on anvil and pm-cpu:
[BFB]