-
Notifications
You must be signed in to change notification settings - Fork 371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For muller-gpu, add -DKokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC=OFF
#6423
Merged
ndkeen
merged 2 commits into
master
from
ndk/machinefiles/pm-gpu-Kokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC=OFF
May 21, 2024
Merged
For muller-gpu, add -DKokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC=OFF
#6423
ndkeen
merged 2 commits into
master
from
ndk/machinefiles/pm-gpu-Kokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC=OFF
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndkeen
added
Machine Files
kokkos
pm-gpu
Perlmutter machine at NERSC (GPU nodes)
labels
May 16, 2024
|
bartgol
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a similar commit to #6421 . I don't really care which PR this fix is attached to. That one is already in next though. Either way, I'm approving, just in case that one has issues.
it doesnt look like you made the change to muller-gpu? |
ndkeen
changed the title
For pm-gpu, add
For muller-gpu, add May 20, 2024
-DKokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC=OFF
-DKokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC=OFF
ndkeen
added a commit
that referenced
this pull request
May 20, 2024
…ASYNC=OFF' into next (PR #6423) After #6101 which brings in kokkos 4.2, we see runtime error with a test like: ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu hits runtime error like: 0: (GTL DEBUG: 0) cuIpcGetMemHandle: invalid argument, CUDA_ERROR_INVALID_VALUE, line no 97 unfortunately, the tests hitting this error are also hanging... A fix that seems to work is to add this build flag: -DKokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC=OFF The fix is merged in another PR for pm-gpu, so this PR just makes same change to muller-gpu. Fixes #6422
merged to next |
ndkeen
deleted the
ndk/machinefiles/pm-gpu-Kokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC=OFF
branch
May 21, 2024 22:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #6101 which brings in kokkos 4.2, we see runtime error with a test like:
ERP_Ln9.ne4pg2_ne4pg2.F2010-SCREAMv1.pm-gpu_gnugpu
hits runtime error like:
unfortunately, the tests hitting this error are also hanging...
A fix that seems to work is to add this build flag:
-DKokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC=OFF
The fix is merged in another PR for pm-gpu, so this PR just makes same change to muller-gpu.
Fixes #6422