Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes floating invalid in co2_diagnostics module #6275

Merged
merged 1 commit into from
May 3, 2024
Merged

Fixes floating invalid in co2_diagnostics module #6275

merged 1 commit into from
May 3, 2024

Conversation

beharrop
Copy link
Contributor

@beharrop beharrop commented Mar 2, 2024 •
edited by rljacob
Loading

Floating invalid error was occurring in co2_diagnostics module. This fix sets global mean arrays to fill values.

Fixes #6185.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6275/
on branch gh-pages at 2024-03-02 02:09 UTC

@rljacob rljacob requested a review from ndkeen March 4, 2024 01:52
@ndkeen
Copy link
Contributor

ndkeen commented Mar 4, 2024

I tested the following which passed:

SMS_D_Ld9.ne4pg2_oQU480.F2010.pm-cpu_intel.eam-thetahy_sl_pg2_mass
SMS_D_Ln5.ne30pg2_r05_EC30to60E2r2.BGCEXP_LNDATM_CNPRDCTC_1850.pm-cpu_gnu
SMS_D_Ln5.ne30pg2_r05_EC30to60E2r2.BGCEXP_LNDATM_CNPRDCTC_1850.pm-cpu_intel

and this test now fails with a different error

SMS_D_Ld2.ne30pg2_r05_EC30to60E2r2.BGCEXP_CNTL_CNPECACNT_1850.pm-cpu_intel.elm-bgcexp

@rljacob
Copy link
Member

rljacob commented Apr 5, 2024

@beharrop is this still a draft?

@beharrop
Copy link
Contributor Author

@rljacob I think this is good to go, unless @ndkeen believes the errors from the SMS_D_Ld2.ne30pg2_r05_EC30to60E2r2.BGCEXP_CNTL_CNPECACNT_1850.pm-cpu_intel.elm-bgcexp test are related.

@ndkeen
Copy link
Contributor

ndkeen commented Apr 15, 2024

I would say if this resolves an issue, then proceed. If there is another problem, we can create another issue.

@beharrop
Copy link
Contributor Author

Works for me. I'll mark it ready for review.

@beharrop beharrop marked this pull request as ready for review April 15, 2024 17:37
@rljacob rljacob added this to the v3.0.1 milestone Apr 26, 2024
@rljacob
Copy link
Member

rljacob commented May 2, 2024

@wlin7 please merge this.

wlin7 added a commit that referenced this pull request May 3, 2024
@wlin7
Merge branch 'beharrop/atm/fix-floating-invalid-co2-diags' into next …
866335c 
…(PR #6275)

Fixes floating invalid in co2_diagnostics module

Floating invalid error was occurring in co2_diagnostics module. This fix sets
global mean arrays to fill values.

Fixes #6185.

[BFB]

* origin/beharrop/atm/fix-floating-invalid-co2-diags:
  Fixes floating invalid in co2_diagnostics module from poorly initialized fields
@wlin7 wlin7 added the BFB PR leaves answers BFB label May 3, 2024
@wlin7
Copy link
Contributor

wlin7 commented May 3, 2024

Merged to next.

@wlin7 wlin7 merged commit ae1c470 into master May 3, 2024
11 checks passed
@wlin7 wlin7 deleted the beharrop/atm/fix-floating-invalid-co2-diags branch May 3, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkeen ndkeen ndkeen approved these changes

Assignees

@wlin7 wlin7

Labels
Atmosphere BFB PR leaves answers BFB bug fix PR
Projects
None yet
Milestone
v3.0.1
4 participants
@beharrop @ndkeen @rljacob @wlin7