Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update run-script example for v3 #6274

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

rljacob
Copy link
Member

@rljacob rljacob commented Mar 1, 2024

Update run-script example for v3 and pm-cpu
change user_nl settings to match v3 production config.

[BFB]

Update run-script example for v3 and pm-cpu
change user_nl settings to match v3 production config.
@rljacob rljacob added the run_e3sm issues related to the script used to submit simulations by many in the project. label Mar 1, 2024
@rljacob rljacob added this to the v3.0.0 milestone Mar 1, 2024
@rljacob rljacob requested review from wlin7 and forsyth2 March 1, 2024 04:58
@rljacob rljacob self-assigned this Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6274/
on branch gh-pages at 2024-03-01 05:00 UTC

rljacob added a commit that referenced this pull request Mar 1, 2024
Update run-script example for v3 and pm-cpu
change user_nl settings to match v3 production config.

[BFB]
@rljacob
Copy link
Member Author

rljacob commented Mar 1, 2024

@wlin7 or @forsyth2 can one of you approve this?

@forsyth2
Copy link
Contributor

forsyth2 commented Mar 1, 2024

@rljacob It's been a while since I've done any work on this. I haven't run any v3 simulations to know if these updates are the proper ones. Is there testing I need to do?

@rljacob
Copy link
Member Author

rljacob commented Mar 1, 2024

I've tested it on pm-cpu. I just need a review to use the green merge button.

Copy link
Contributor

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Again, I can't say if all these changes are "correct", but since you've tested successfully on Perlmutter, I'll go ahead and approve. Thanks.

Copy link
Contributor

@forsyth2 forsyth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Again, I can't say if all these changes are "correct", but since you've tested successfully on Perlmutter, I'll go ahead and approve. Thanks.

@rljacob rljacob merged commit 6c2f78d into master Mar 1, 2024
10 checks passed
@rljacob rljacob deleted the rljacob/update-run-script branch March 1, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_e3sm issues related to the script used to submit simulations by many in the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants