Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single Column Model Updates & Fixes for v3 #6254

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Single Column Model Updates & Fixes for v3 #6254

merged 4 commits into from
Apr 26, 2024

Conversation

bogensch
Copy link
Contributor

@bogensch bogensch commented Feb 23, 2024 •
edited by wlin7
Loading

Modify and fix the single column model (SCM) to make it compatible with master and v3. Specifically:

  1. The config_component for SCM_EAM has been changed to “scam_generic” (which should have never been changed). When running cases with the standardized scripts prescribed aerosols are used, which is not compatible with the scm_generic_chemUCI-Linoz-mam5-vbs component currently specified. (Aside: a new prescribed aerosol file has been generated by running E3SM with mam5. This file has been uploaded to the E3SM data server and the E3SM SCM scripts have been updated to use this file).
  2. Idealization flags have been added to the P3 microphysics to allow for:
    1. Runs with no precipitation. Note that in the P3 implementation this only turns off liquid precipitation, which is used in several GCSS boundary layer cloud cases in the E3SM SCM library.
    2. Prescribed droplet concentration. This was already a feature in place in P3 but this PR connects this functionality to the EAM namelist.
  3. Fixes to allow the ability to “replay” a column once again (back by semi-popular demand!). This was a feature that worked in E3SMv1 but has not been functional for sometime. The fix in this PR allows users to generate output needed to make IOP forcing files to replay a single column. Note that additional post-processing is required to actually do an SCM run (in which the user needs to consult with the E3SM wiki page).

Further documentation and scripts have been updated on the E3SM SCM wiki to reflect changes made in this PR (https://github.com/E3SM-Project/scmlib/wiki/E3SM-Single-Column-Model-Home).

[BFB]

All e3sm_developer tests pass on pm-cpu.

@bogensch bogensch added the BFB PR leaves answers BFB label Feb 23, 2024
@bogensch bogensch requested a review from wlin7 February 23, 2024 00:32
@github-actions GitHub Actions
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6254/
on branch gh-pages at 2024-02-23 00:34 UTC

@rljacob rljacob requested review from brhillman and removed request for wlin7 February 23, 2024 01:13
@rljacob
Copy link
Member

rljacob commented Mar 21, 2024

@brhillman please review.

@rljacob
Copy link
Member

rljacob commented Apr 12, 2024

@brhillman please review this

@rljacob rljacob added this to the v3.0.1 milestone Apr 12, 2024
@brhillman
Copy link
Contributor

Looks good. Only comment is flags like do_precip_off are kind of weird, it would make more sense to have a do_precip with a default value of .true., but it looks like precip_off was the original field in the user-facing xml, so it’s maybe not worth breaking existing configuration to make this change.

rljacob
rljacob reviewed Apr 15, 2024
View reviewed changes
components/eam/cime_config/config_component.xml
@@ -136,7 +136,7 @@
<value compset="20TR(?:SOI)?_EAM.*CHEMUCI.*LINOZ.*MAM5" >20TR_eam_chemUCI-Linoz-mam5</value>
<value compset="ARM95_EAM" >scam_arm95</value>
<value compset="ARM97_EAM" >scm_arm97_chemUCI-Linoz-mam5-vbs</value>
<value compset="SCM_EAM" >scm_generic_chemUCI-Linoz-mam5-vbs</value>
<value compset="SCM_EAM" >scam_generic</value>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogensch should we add a test of this compset? We only test ARM97_EAM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's probably wise. I'll try to get this done before I leave for vacation tomorrow afternoon... else expect a period of radio silence (FYI).

Copy link
Contributor

@wlin7 wlin7 Apr 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a new testmod for it, to bring in some of the settings specified in SCM case scripts to allow setup to proceed. (e.g., scmlat, scmlon). May need one for the replay feature as well.

@wlin7
Copy link
Contributor

wlin7 commented Apr 18, 2024

Hi @bogensch , thanks for working to update the SCM configuration. I didn't realize when putting in v3atm that SCM run scripts rely on the generic use_case file. I modified the use_case for the nightly ARM97 test, and without careful thinking, also applied the changes to the generic one. As Rob suggested, a test using scam_generic will be useful for protecting this configuration. It can replace the other test (FSCM-ARM97) or revert the change in its use_case file and associated config option to be more like scam_generic.

Unrelated to this PR itself: I found the link to the 'desired cases' on the instruction for 'Running the single column model' returns a page that I didn't expect: It
would be to Create a new page. I am not sure if this is intended and how it works if so.

Also have a few comments on the run script, if you have time to update them in the near future.

  • Can replace machine cori with pm-cpu, and $CSCRATCH with $PSCRATCH
  • Line 198 of the runscript has a duplicated keyword 'set'
  • a number of if-logics are conditioned on if the code version is 'master' . Users may not fully comprehend the distinction you try to convey. Maybe some like 'v3x' to use either master or any variant branch a user creates?
  • namelist parameter values in the script going to user_nl_eam. Right now there is no distinction between v2 and v3. Most of them should have been set by default, given v2 or v3 code base. Can we remove those that are not SCM specific?

wlin7
wlin7 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@wlin7 wlin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR itself looks good. Verified atm_developer tests remain BFB.

@rljacob
Copy link
Member

rljacob commented Apr 18, 2024

@wlin7 you can start merging this if you want. We could wait and add the test in a later PR.

@bogensch
Copy link
Contributor Author

@wlin7 thanks for your careful review... not only of the code but for the scripts. I will incorporate your great suggestions to the scripts.

@wlin7
Copy link
Contributor

wlin7 commented Apr 24, 2024

Thank you, @bogensch . As the scripts are not part of this PR, I can start merging today if next is open, while you work on updating the run scripts.

@wlin7 wlin7 changed the title Single Column Model Updates & Fixes for master/v3 Single Column Model Updates & Fixes for v3 Apr 25, 2024
wlin7 added a commit that referenced this pull request Apr 25, 2024
@wlin7
Merge branch 'bogensch/atm/SCMmods_for_v3' into next (PR #6254)
399e829 
Single Column Model updates & fixes for v3

Modify and fix the single column model (SCM) to make it compatible with v3. Specifically:

1. The config_component for SCM_EAM has been changed to “scam_generic”
   (which should have never been changed).  When running cases with the standardized
   scripts prescribed aerosols are used, which is not compatible with the
   scm_generic_chemUCI-Linoz-mam5-vbs component currently specified.
   (Aside: a new prescribed aerosol file has been generated by running E3SM with mam5.
   This file has been uploaded to the E3SM data server and the E3SM SCM scripts
   have been updated to use this file).

2. Idealization flags have been added to the P3 microphysics to allow for:
    i. Runs with no precipitation.  Note that in the P3 implementation this only
       turns off liquid precipitation, which is used in several GCSS boundary
       layer cloud cases in the E3SM SCM library.
   ii. Prescribed droplet concentration.  This was already a feature in place
       in P3 but this PR connects this functionality to the EAM namelist.

3. Fixes to allow the ability to “replay” a column once again (back by semi-popular demand!).
   This was a feature that worked in E3SMv1 but has not been functional for sometime.  The fix in
   this PR allows users to generate output needed to make IOP forcing files to replay a single column.
   Note that additional post-processing is required to actually do an SCM run (in which the user
   needs to consult with the E3SM wiki page).

Further documentation and scripts have been updated on the E3SM SCM wiki to reflect changes made in this PR
(https://github.com/E3SM-Project/scmlib/wiki/E3SM-Single-Column-Model-Home).

[BFB]
@wlin7
Copy link
Contributor

wlin7 commented Apr 25, 2024

Merged to next.

@wlin7 wlin7 merged commit ac74182 into master Apr 26, 2024
10 checks passed
@wlin7 wlin7 deleted the bogensch/atm/SCMmods_for_v3 branch April 26, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rljacob rljacob rljacob left review comments

@brhillman brhillman brhillman approved these changes

@wlin7 wlin7 wlin7 approved these changes

Assignees

@wlin7 wlin7

Labels
Atmosphere BFB PR leaves answers BFB
Projects
None yet
Milestone
v3.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@bogensch @rljacob @brhillman @wlin7