Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for 0.25 deg ELM and MOSART grids #6212

Merged
merged 8 commits into from
Apr 10, 2024

Conversation

bishtgautam
Copy link
Contributor

@bishtgautam bishtgautam commented Feb 6, 2024

  • Adds 0.25 deg ELM surface dataset for 1850 and 2010.
  • These new surface datasets include the TOP subgrid solar radiation scheme parameters.
  • Adds three new -res <r025_IcoswISC30E3r5 | ne120pg2_r025_IcoswISC30E3r5 | ne30pg2_r025_IcoswISC30E3r5.
    In these -res, MOSART is inactive because a mapping between MOSART at r025 and OCN at
    IcoswISC30E3r5 is omitted.
  • Adds a fourth new -res r025_r025 for ELM+MOSART simulation.
  • Includes linear and nonlinear maps for the following:
    • ne120np4.pg2 (atm) and r025 (lnd)
    • ne30np4.pg2 (atm) and r025 (lnd)

[BFB]

Copy link

github-actions bot commented Feb 6, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6212/
on branch gh-pages at 2024-03-25 19:08 UTC

@bishtgautam
Copy link
Contributor Author

  1. ELM only case with BGC + TOP solar parameterization for 1850 ran successfully for 5-days
./create_newcase \
-case r025_IcoswISC30E3r5.I1850CNPRDCTCBCTOP.chrysalis.5151ecfc87.2024-02-06 \
-res r025_IcoswISC30E3r5 \
-mach chrysalis \
-compiler intel \
-compset I1850CNPRDCTCBCTOP

@bishtgautam bishtgautam changed the title [WIP] Adds support for 0.25 deg ELM grid Adds support for 0.25 deg ELM grid Feb 14, 2024
@bishtgautam bishtgautam added Land BFB PR leaves answers BFB labels Feb 15, 2024
@rljacob
Copy link
Member

rljacob commented Feb 29, 2024

@wlin7 @acme-y9s please review.

@rljacob
Copy link
Member

rljacob commented Mar 21, 2024

notes: Some Chrysalis testing suggested issues but could have been from OS/firmware updates on Chrysalis (since rolled back).

@bishtgautam bishtgautam changed the title Adds support for 0.25 deg ELM grid Adds support for 0.25 deg ELM and MOSART grids Mar 25, 2024
@bishtgautam bishtgautam requested review from hydrotian and removed request for wlin7 March 25, 2024 19:34
@bishtgautam
Copy link
Contributor Author

@hydrotian Could you please review the MOSART-related settings in this PR?
@acme-y9s Could you please review the ELM-related settings in this PR?

@hydrotian
Copy link
Contributor

@bishtgautam The MOSART-related settings look okay to me.
@rljacob I noticed that from #5979 MOSART started to require a mesh file frivinp_mesh for integration with the MOAB coupler. From my understanding, MOSART should produce BFB results when using either the MOAB coupler (with the mesh file) or the MCT coupler (without a mesh file). Is that correct?

@rljacob
Copy link
Member

rljacob commented Mar 26, 2024

No it won't be BFB because of slight differences in how mapping weights are calculated online vs. offline.
The mesh file is ignored when using the MCT coupler.

peterdschwartz added a commit that referenced this pull request Apr 9, 2024
Adds 0.25 deg ELM surface dataset for 1850 and 2010.
These new surface datasets include the TOP subgrid solar radiation scheme parameters.
Adds three new -res <r025_IcoswISC30E3r5 | ne120pg2_r025_IcoswISC30E3r5 | ne30pg2_r025_IcoswISC30E3r5.
In these -res, MOSART is inactive because a mapping between MOSART at r025 and OCN at
IcoswISC30E3r5 is omitted.
Adds a fourth new -res r025_r025 for ELM+MOSART simulation.
Includes linear and nonlinear maps for the following:
ne120np4.pg2 (atm) and r025 (lnd)
ne30np4.pg2 (atm) and r025 (lnd)

[BFB]
@peterdschwartz
Copy link
Contributor

merged to next

@peterdschwartz peterdschwartz merged commit 756debc into master Apr 10, 2024
11 checks passed
@peterdschwartz peterdschwartz deleted the bishtgautam/lnd/r025 branch April 10, 2024 18:31
@peterdschwartz
Copy link
Contributor

merged to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB Land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants