remove seq_flds dependency for mpas_moabmesh #6168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpas framework should not depend on driver/shr this was a mistake
|
|
@iulian787 -- do we need to do something similar for mpas-albany-landice? Or has moab not been integrated for all components? |
|
We haven't done land ice yet. |
|
I mean we have not integrated MOAB to land ice so nothing to do there in this PR. |
|
With the extra commit I pushed, I was able to successfully compile standalone MPAS-Ocean on Perlmutter with the |
|
@sbrus89 can you approve this? |
jonbob
approved these changes
Jan 29, 2024
sbrus89
approved these changes
Jan 29, 2024
rljacob
added a commit
that referenced
this pull request
Jan 30, 2024
Remove mpas framework dependency on driver-moab/shr mpas ocean cannot be built in standalone mode with MOAB, because of this [BFB]
|
merged to next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpas framework should not depend on driver-moab/shr
mpas ocean cannot be built in standalone mode with MOAB, because of this
[BFB]