Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstream merge of scream/eamxx fork into E3SM #6153

Merged
merged 1,355 commits into from
Jan 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1355 commits
Select commit Hold shift + click to select a range
9308db5
Fix ascent macro
jgfouca Nov 13, 2023
8e28e91
Merge Pull Request #2596 from E3SM-Project/scream/bartgol/io/fp-preci…
E3SM-Bot Nov 14, 2023
7b4de1b
Merge Pull Request #2598 from E3SM-Project/scream/jgfouca/fix_builds
E3SM-Bot Nov 14, 2023
a99e38a
Disable snan init for cice
jgfouca Nov 15, 2023
1bdd7eb
Merge Pull Request #2599 from E3SM-Project/scream/jgfouca/disable_sna…
E3SM-Bot Nov 15, 2023
c78fa38
typos in docs strings
mahf708 Nov 16, 2023
10b5566
start setting up unit test for rrtmgp_[sl]w
mahf708 Nov 16, 2023
d797fb7
add sanity check of sw clnsky to rrtmgp_tests
mahf708 Nov 16, 2023
26f1eda
Merge Pull Request #2587 from E3SM-Project/scream/tcclevenger/dp/setu…
E3SM-Bot Nov 16, 2023
8f43e4d
fix bug in lw cln/clr calls and add checks
mahf708 Nov 17, 2023
4bb58b1
Fix chrysalis cmake macro to fix DIFFs
jgfouca Nov 17, 2023
7cb3c20
Merge Pull Request #2600 from E3SM-Project/scream/jgfouca/fix_chrys_d…
E3SM-Bot Nov 18, 2023
f887c85
comment out rrtmgp_[ls]w unit test for now
mahf708 Nov 20, 2023
14c61fa
EAMxx: Allow to flush output files before they are closed
bartgol Nov 20, 2023
28a500c
EAMxx: fix typo
bartgol Nov 20, 2023
d306f09
Modifies CMAKE to send SCREAM CMAKE info to HAERO/MAM4xx
singhbalwinder Nov 22, 2023
9fcab48
Removes Fortran cmake
singhbalwinder Nov 22, 2023
e1f4b1d
EAMxx: rename cxx_blah wrapper to avoid conflict with one from Homme
bartgol Nov 22, 2023
4c8dccd
Merge pull request #2606 from E3SM-Project/bartgol/rename-cxx-wraps
bartgol Nov 22, 2023
104b9eb
EAMxx: small mod to CreateUnitTest
bartgol Nov 21, 2023
607960d
EAMxx: add default source file and cmake utility to create AD unit test
bartgol Nov 21, 2023
a912c62
EAMxx: adapt unit tests to recent changes, plus fixes
bartgol Nov 21, 2023
48f3a92
EAMxx: always add scream_share as a LIB dep to all unit tests
bartgol Nov 21, 2023
730b636
EAMxx: use PUBLIC explicitly in target_link_libraries
bartgol Nov 22, 2023
80263d3
EAMxx: silence compiler warning
bartgol Nov 22, 2023
261025d
EAMxx: fix some tests dependencies
bartgol Nov 22, 2023
97f5495
EAMxx: fix typo bug in fail_check test
bartgol Nov 22, 2023
2aa4942
EAMxx: remove un-needed test dependency
bartgol Nov 22, 2023
ba5c41b
EAMxx: fix some typos in unit tests names
bartgol Nov 22, 2023
cf8544e
EAMxx: removed pointless spec in shoc_p3_nudged tests
bartgol Nov 22, 2023
144caa6
Merge Pull Request #2605 from eagles-project/scream/singhbalwinder/cm…
E3SM-Bot Nov 24, 2023
f352589
guard compute-heavy statements by runtime flags
mahf708 Nov 25, 2023
20a3320
add docs
mahf708 Nov 25, 2023
f8bcb20
add new runtimes flags to defaults as false
mahf708 Nov 25, 2023
1a636a8
perlmutter --> pm-gpu
mahf708 Nov 25, 2023
8f314db
for the tests to pass, must default to true (if not set)
mahf708 Nov 25, 2023
09786ea
set lw fluxes to zero
mahf708 Nov 25, 2023
7265c7c
initial attempt for nudging from coarse data
mahf708 Nov 24, 2023
24b0bbe
Update PAM to work with YAKL updates
brhillman Nov 27, 2023
87736ff
EAMxx: revert dp coupled test to not use CreateADUnitTest
bartgol Nov 27, 2023
d95daf2
EAMxx: for GM/AtmProc, prefer using registration function over manual…
bartgol Nov 27, 2023
6c4347b
Merge Pull Request #2603 from E3SM-Project/scream/bartgol/io/allow-se…
E3SM-Bot Nov 27, 2023
885d998
remove cori-knl as it is deprcated
mahf708 Nov 27, 2023
22bf3d9
Merge Pull Request #2610 from mahf708/scream/fix-pm-machine-stuff
E3SM-Bot Nov 27, 2023
538519f
Update mam4xx submodule to the latest main version
singhbalwinder Nov 27, 2023
85488aa
fix logic of intermediate grid
mahf708 Nov 27, 2023
7d56173
EAMxx: fix yaml file name in dp coupled test
bartgol Nov 28, 2023
462317a
fix namelist and grid names
mahf708 Nov 28, 2023
9dfe08a
fix bug caused by logicals left unset in namelist
mahf708 Nov 28, 2023
8737855
define grid_name for the use_weights guard
mahf708 Nov 28, 2023
4dae3ba
separate the remapper registration into a different for-loop
mahf708 Nov 28, 2023
c2df3b8
add printing hyperslaps
mahf708 Nov 28, 2023
70cc88e
move horiz remap outside for-loop
mahf708 Nov 28, 2023
e3b28d1
move registration to init_impl
mahf708 Nov 28, 2023
2920759
EAMxx: fix dp bfb tests FIXTURES_REQUIRED
bartgol Nov 28, 2023
046746f
Merge Pull Request #2609 from E3SM-Project/scream/bartgol/eamxx-ad-tests
E3SM-Bot Nov 28, 2023
2de9f80
Merge Pull Request #2615 from eagles-project/scream/singhbalwinder/up…
E3SM-Bot Nov 29, 2023
7fba308
Merge Pull Request #2588 from E3SM-Project/scream/elynn/update-ml-cor…
E3SM-Bot Nov 29, 2023
edf56a0
EAMxx: add cmake utility to create a list containing range of integers
bartgol Nov 29, 2023
c57acce
EAMxx: add cmake utility to generate bfb comparison tests for a famil…
bartgol Nov 29, 2023
5e36d6f
EAMxx: use utility to create nc files bfb comparison tests across tes…
bartgol Nov 29, 2023
1b83dd9
Updates haero submodule to its latest main branch
singhbalwinder Nov 29, 2023
79fd7f1
EAMxx: fix output file meta name in one of the PEM unit tests
bartgol Nov 29, 2023
54cc926
Merge Pull Request #2617 from eagles-project/scream/singhbalwinder/up…
E3SM-Bot Nov 29, 2023
962a730
EAMxx: fix fixtures logic in shoc standalone tests
bartgol Nov 29, 2023
e6dac66
Merge pull request #2597 from E3SM-Project/jgfouca/revert_unneeded_ma…
jgfouca Nov 29, 2023
7b86cb4
restructure code based on luca's comments
mahf708 Nov 29, 2023
6a2f266
EAMxx: enhanced CompareNCFiles script
bartgol Nov 29, 2023
d2e0711
Merge Pull Request #2616 from E3SM-Project/scream/bartgol/nc-compare-…
E3SM-Bot Nov 29, 2023
efe29b9
Merge Pull Request #2618 from E3SM-Project/scream/bartgol/fix-shoc-st…
E3SM-Bot Nov 30, 2023
ec773f7
reorg includes
mahf708 Nov 30, 2023
a9fce39
do shallow grid clones only
mahf708 Nov 30, 2023
43dfc57
don't unnecessarily change existing code style
mahf708 Nov 30, 2023
3159e9d
add impl comment on remap ops
mahf708 Nov 30, 2023
b324eac
revert more accidental auto formatting
mahf708 Nov 30, 2023
430a6e4
add back space before paran to keep style consistent
mahf708 Nov 30, 2023
cd1b5c1
Process IOP file data
tcclevenger Oct 31, 2023
d109bcc
reorg boolean logic and other refines
mahf708 Nov 30, 2023
0325c57
no need for another grid_name call
mahf708 Nov 30, 2023
c5c1d89
simplify and rename hxt to tmp
mahf708 Nov 30, 2023
cec11cc
Fix: correct_temperature() needs to be public
tcclevenger Nov 30, 2023
387e6f3
fix includes
mahf708 Nov 30, 2023
6aacee5
improve docs and restructure some code
mahf708 Nov 30, 2023
8d94db6
Fix: GPU errors, illegal access
tcclevenger Nov 30, 2023
26994c4
check nuding files, mapfile, and remapper
mahf708 Nov 30, 2023
ee91955
no need to register/close files
mahf708 Dec 1, 2023
a7be762
add a warning if user provided mapfile, but we are not remapping
mahf708 Dec 1, 2023
c48e85c
small adjustment in error message format
mahf708 Dec 1, 2023
0118911
fix error msg fmt again
mahf708 Dec 1, 2023
506464b
Add 'Coarse nudging' to docs
mahf708 Dec 1, 2023
1153767
Correct computation for adjusted file levels
tcclevenger Dec 1, 2023
1ccbcbd
Move iop class object to AP base class
tcclevenger Dec 1, 2023
9a6b402
Use std::vector instead of VLA, auto when possible
tcclevenger Dec 1, 2023
4dbe6e9
Compute shoc dx and dy during initialization
tcclevenger Dec 1, 2023
0ccca3d
Use ptr to last view entry for loading srf data
tcclevenger Dec 4, 2023
86083b7
Remove unneded include
tcclevenger Dec 4, 2023
5e24986
Use field dim instead of last extent
tcclevenger Dec 4, 2023
2b0a854
EAMxx: Add missing header guard.
ambrad Dec 4, 2023
86fbc68
Merge branch 'master' into elynn/update-ml-radiative-fluxes
elynnwu Dec 4, 2023
8d8bd9d
Merge branch 'master' of github.com:E3SM-Project/scream into elynn/up…
elynnwu Dec 4, 2023
9e3be7b
Merge Pull Request #2594 from E3SM-Project/scream/elynn/update-ml-rad…
E3SM-Bot Dec 4, 2023
c7be2ab
Merge Pull Request #2623 from E3SM-Project/scream/ambrad/scream/fix-b…
E3SM-Bot Dec 5, 2023
310a5fe
Add a correction to qv
tcclevenger Dec 5, 2023
2287b78
Only correct qv if T_iop==0
tcclevenger Dec 6, 2023
a690154
update unit test to include required input fields
elynnwu Dec 6, 2023
4c6ec29
Require iop file, T, and q
tcclevenger Dec 6, 2023
70a9509
Merge Pull Request #2625 from E3SM-Project/scream/elynn/fix-ML-unit-test
E3SM-Bot Dec 6, 2023
cda33a1
Merge Pull Request #2619 from E3SM-Project/scream/tcclevenger/dp/proc…
E3SM-Bot Dec 7, 2023
673f1d4
Fix two bugs in IO regarding average tracking and sliced output.
AaronDonahue Dec 7, 2023
068d3ea
fix comment in scorpio_output
AaronDonahue Dec 7, 2023
b309b8b
EAMxx: avoid exposing IOP data structure to atm process class
bartgol Dec 7, 2023
ecb2ea8
EAMxx: set iop in SC importer
bartgol Dec 7, 2023
6ac8b91
cleanup up the way avg cnt tracking fields are named
AaronDonahue Dec 7, 2023
ff41c92
EAMxx: fix constness issue
bartgol Dec 8, 2023
41bb09e
Merge Pull Request #2626 from E3SM-Project/scream/aarondonahue/fix_fi…
E3SM-Bot Dec 8, 2023
55e9335
EAMxx: circumvent issue of writing 0-dim var in scorpio
bartgol Dec 8, 2023
64d3217
Merge Pull Request #2627 from E3SM-Project/scream/bartgol/iop/set-dx-…
E3SM-Bot Dec 8, 2023
710bb6d
Merge remote-tracking branch 'upstream/master' into jgfouca/upstream_…
jgfouca Dec 11, 2023
3329a76
Use correct compiler settings for crayclang-scream_frontier-scream-gp…
jgfouca Dec 11, 2023
43e09e0
Update scream macros
jgfouca Dec 11, 2023
f86e399
remove logger print call in tests
mahf708 Dec 11, 2023
6916ef3
remove commented test attempt
mahf708 Dec 11, 2023
9495b97
add type and docs for new namelist variables
mahf708 Dec 11, 2023
67f80d1
add type and docs for more variables that I know for sure
mahf708 Dec 11, 2023
911d885
reduce number of conditional branches
mahf708 Dec 11, 2023
3bbbd67
fix namelist typo and format new namelist additions
mahf708 Dec 11, 2023
3b27e19
fix typo in line comments
mahf708 Dec 11, 2023
94a8ac8
address mostly doc comments from reviews
mahf708 Dec 11, 2023
d89cff0
add a vertical cutoff
mahf708 Dec 11, 2023
3f8ec91
Ascent: Add -forward-unknown-to-host-compiler, which may resolve the …
ambrad Dec 11, 2023
bd5d16b
add doc strings to vertical cutoff logic
mahf708 Dec 11, 2023
255c288
better align namelist parameters on multi-line code
mahf708 Dec 11, 2023
bfee1f4
Merge remote-tracking branch 'upstream/master' into jgfouca/upstream_…
jgfouca Dec 11, 2023
8b32648
Fix and better document vertical cutoff branch
mahf708 Dec 11, 2023
f85d4b2
Merge Pull Request #2634 from E3SM-Project/scream/ambrad/eamxx/fix-as…
E3SM-Bot Dec 12, 2023
ce55580
fix critical typos in vertical cutoff code
mahf708 Dec 12, 2023
4b8bb9b
move apply_vert_cutoff to public for cuda
mahf708 Dec 12, 2023
e894ac3
remove apply_vert_cutoff from private for coda
mahf708 Dec 12, 2023
d72a625
Merge Pull Request #2581 from mahf708/scream/cln-clnclr-sky-rads
E3SM-Bot Dec 12, 2023
b7c5056
EAMxx: init active gases workaround from RRTMGP rather than the driver
bartgol Dec 12, 2023
49eb08e
EAMxx: init fvphyshack from HommeGridsManager
bartgol Dec 12, 2023
bee7f48
EAMxx: change type of usage of o3 field in RRTMGP
bartgol Dec 12, 2023
c81aab9
EAMxx: remove all mentions of Pack from rrtmgp interface
bartgol Dec 12, 2023
ac7672e
EAMxx: enforce consistence between restart and radiation frequency
bartgol Dec 12, 2023
e81acad
EAMxx: pass number of physical levs to trcmix
bartgol Dec 13, 2023
deb31b8
EAMxx: compute active gases VMR before the chunk loop
bartgol Dec 13, 2023
2ed98d4
EAMxx: fix o3-related bug introduced a few commits back
bartgol Dec 13, 2023
a403853
Merge remote-tracking branch 'origin/master' into jgfouca/upstream_me…
jgfouca Dec 13, 2023
22f2b96
EAMxx: set n2/co vmr at init time rather than run time
bartgol Dec 13, 2023
9524dde
EAMxx: fix handling of o3 field in rad
bartgol Dec 13, 2023
fa6e35c
EAMxx: fix compiler warning
bartgol Dec 13, 2023
daedc96
EAMxx: do not use packs in long/short wave cld forcing diags
bartgol Dec 13, 2023
1029d08
EAMxx: bug fix in trcmix call in rrtmgp interface
bartgol Dec 13, 2023
576d9b7
Fixes for building cprnc
jgfouca Dec 13, 2023
a3f6ea7
EAMxx: fix initialization of TraceGasesWorkaround in rrtmgp
bartgol Dec 13, 2023
6a21d8c
EAMxx: change STOP_N for rad_frequency_2 cime test
bartgol Dec 14, 2023
f5c0991
Merge Pull Request #2613 from mahf708/scream/coarse-nudging
E3SM-Bot Dec 14, 2023
5799318
EAMxx: minor mod to eamxx buildlib_cmake
bartgol Dec 14, 2023
5e31682
EAMxx: add 'append' metadata attribute in namelist defaults
bartgol Dec 14, 2023
67a8e0c
Merge pull request #2638 from E3SM-Project/bartgol/eamxx/change-stop-…
bartgol Dec 14, 2023
7cb3529
EAMxx, Ascent: Work around apparent --fmad=false bug.
ambrad Dec 15, 2023
fe3f7ab
Merge pull request #2633 from E3SM-Project/jgfouca/upstream_merge_202…
jgfouca Dec 15, 2023
6731831
EAMxx: fix pylint error
bartgol Dec 18, 2023
ab205af
EAMxx, Ascent: Use SCREAM_MACHINE to limit workaround to Ascent.
ambrad Dec 18, 2023
e5d290c
Merge Pull Request #2641 from E3SM-Project/scream/ambrad/eamxx/ascent…
E3SM-Bot Dec 18, 2023
e901950
Merge pull request #2640 from E3SM-Project/bartgol/eamxx/namelist-def…
bartgol Dec 19, 2023
35d8f38
Merge pull request #2636 from E3SM-Project/bartgol/active-gases-pg2-a…
bartgol Dec 20, 2023
6e21ec9
EAMxx: avoid expensive and pointless stuff in VerticalRemapper constr…
bartgol Dec 20, 2023
6e86b71
EAMxx: simplify an internal method of VerticalRemapper
bartgol Dec 20, 2023
d4c399c
EAMxx: no need to set geo data in cloned grid in VerticalRemapper con…
bartgol Dec 20, 2023
f0910de
EAMxx: remove too stringent check in AbstractRemapper
bartgol Dec 20, 2023
a1955ef
EAMxx: add layout check methods to remapper classes
bartgol Dec 20, 2023
80eca35
enable ruby to execucte ML corrected run
elynnwu Dec 20, 2023
832c27e
EAMxx: move the layout compatibility method to the grid class
bartgol Dec 20, 2023
4989dad
Merge Pull Request #2643 from E3SM-Project/scream/elynn/enable-ruby-M…
E3SM-Bot Dec 20, 2023
6f31241
EAMxx: when resetting nlev in a grid, erase all geo data that has levels
bartgol Dec 21, 2023
0621ae2
EAMxx: allow to construct a Field from a pre-existing view
bartgol Dec 21, 2023
ec19dbe
EAMxx: make field unit test more interesting
bartgol Dec 21, 2023
587cf26
EAMxx: bug fix to AbstractGrid::is_valid_layout
bartgol Dec 21, 2023
2ccc1aa
EAMxx: fix bug in nudging interface
bartgol Dec 21, 2023
c6382a2
Add perturb() field utility with test.
tcclevenger Dec 8, 2023
c3b3efb
Apply random perturbation in set_initial_conditions().
tcclevenger Dec 8, 2023
5485fa0
fix comment typos
tcclevenger Dec 14, 2023
d70d857
Use perturbation_minimum_pressure for param name
tcclevenger Dec 14, 2023
c3dc9c3
Add field1.scale(field2) function
tcclevenger Dec 20, 2023
f188c05
Update random perturbation computation
tcclevenger Dec 20, 2023
16d926e
EAMxx: add support for other tags when detecting/building a vector la…
bartgol Dec 21, 2023
f40f29d
EAMxx: fix nvcc compilation error
bartgol Dec 21, 2023
6bb16d5
EAMxx: bug fix in get_layout_type
bartgol Dec 21, 2023
4d09464
Merge Pull Request #2644 from E3SM-Project/scream/bartgol/field-from-…
E3SM-Bot Dec 22, 2023
bab860e
Merge Pull Request #2642 from E3SM-Project/scream/bartgol/eamxx/fix-v…
E3SM-Bot Dec 22, 2023
ffabed4
EAMxx: cache the result of AbstractGrid::is_unique
bartgol Dec 22, 2023
7e8078e
EAMxx: fix implementation of AbstractGrid::is_unique
bartgol Dec 22, 2023
8925a12
EAMxx: See if removing --fmad=false fixes nondeterminism in pm-gpu ni…
ambrad Dec 29, 2023
c5b7c31
Merge pull request #2648 from E3SM-Project/ambrad/eamxx/pm-gpu-fmad-try
ambrad Dec 29, 2023
8efe2ec
EAMxx: Specialize --fmad=false workaround to just Ascent and pm-gpu.
ambrad Jan 2, 2024
2f9def8
Merge pull request #2649 from E3SM-Project/ambrad/eamxx/fmad-adjust
ambrad Jan 2, 2024
1729e2b
Fixes for frontier
jgfouca Jan 2, 2024
0ac07e2
More frontier fixes
jgfouca Jan 4, 2024
f7ce020
More fixes
jgfouca Jan 4, 2024
d682541
Build working
jgfouca Jan 5, 2024
2fda00e
remove unnecessary comment
tcclevenger Jan 8, 2024
2d1a55b
Use plain ftn as linker
jgfouca Jan 8, 2024
e83691b
Improve comment on linker
jgfouca Jan 8, 2024
79f0441
Skip blas instead of hardcoding blas_libraries
jgfouca Jan 8, 2024
ffaaa8d
Add comment for SKIP_BLAS
jgfouca Jan 9, 2024
e7b9f5f
Merge pull request #2654 from E3SM-Project/jgfouca/frontier_fixes
jgfouca Jan 9, 2024
f2f2178
Merge Pull Request #2647 from E3SM-Project/scream/bartgol/grid-cache-…
E3SM-Bot Jan 9, 2024
2f238ef
Assume geo data is synced to host
tcclevenger Jan 9, 2024
b8670a9
Improve error messages in perturb()
tcclevenger Jan 9, 2024
15f9a65
EAMxx: print prop check msg when field is repaired
bartgol Jan 9, 2024
e579218
EAMxx: avoid pointless work in FieldWithinIntervalCheck
bartgol Jan 9, 2024
d9ee584
EAMxx: avoid pointless sync to host in FieldWithinIntervalCheck
bartgol Jan 9, 2024
329a173
EAMxx: add timing of pre/post/conservation checks
bartgol Jan 9, 2024
d6c9e6b
EAMxx: fix expected prop check output in unit test
bartgol Jan 10, 2024
64114dd
Merge Pull Request #2659 from E3SM-Project/scream/bartgol/eamxx/prope…
E3SM-Bot Jan 10, 2024
8f1f436
EAMxx: remove unused (and buggy) FieldLayout constructors
bartgol Jan 10, 2024
4196e04
EAMxx: make FieldLayout::invalid() return something different from a …
bartgol Jan 10, 2024
32d421f
Merge Pull Request #2631 from E3SM-Project/scream/tcclevenger/perturb…
E3SM-Bot Jan 10, 2024
9a1e219
Merge Pull Request #2660 from E3SM-Project/scream/bartgol/field-layou…
E3SM-Bot Jan 10, 2024
49dd6b3
EAMxx: ensure accum fields are fully inited before I/O runs
bartgol Jan 11, 2024
67024e9
EAMxx: in scorpio output, only track avg cnt for fields that are outp…
bartgol Jan 11, 2024
14ea624
EAMxx: set initial timestamp for rrtmgp active gases in fvphys init l…
bartgol Jan 11, 2024
1fa8a1b
Merge Pull Request #2664 from E3SM-Project/scream/bartgol/fix-accumul…
E3SM-Bot Jan 11, 2024
cc36493
Merge Pull Request #2665 from E3SM-Project/scream/bartgol/fix-avg-cnt…
E3SM-Bot Jan 11, 2024
da41940
return early in layout check to avoid segfault
mahf708 Jan 13, 2024
dfe5f01
in scorpio interface, only access array when it is not empty
mahf708 Jan 13, 2024
c105dfb
forbid using weighted nudging from coarse data
mahf708 Jan 14, 2024
991fdde
typo
mahf708 Jan 14, 2024
98ba276
Merge Pull Request #2670 from E3SM-Project/scream/2669-is_valid_layou…
E3SM-Bot Jan 15, 2024
8f12645
Merge Pull Request #2672 from E3SM-Project/scream/2671-scorpio-interf…
E3SM-Bot Jan 15, 2024
9f3b148
Merge Pull Request #2673 from E3SM-Project/scream/mahf708/nudging/fix…
E3SM-Bot Jan 15, 2024
97a5c31
Downstream merge of scream/eamxx fork into E3SM
jgfouca Jan 18, 2024
423bc74
eam/micro_p3.F90 was using qv_sat, which is gone.
jgfouca Jan 18, 2024
5ec189b
Only do eamxx github actions when PR is labelled with EAMxx
jgfouca Jan 18, 2024
5fb7d64
rename gh-pages and generate params
mahf708 Jan 19, 2024
595999b
need CIME in e3sm dosc for params gen
mahf708 Jan 19, 2024
6fbe2c6
change conditional on action run
mahf708 Jan 19, 2024
d0e9a4f
Revert change that was not meant for eam physics
jgfouca Jan 19, 2024
258d61b
Revert "eam/micro_p3.F90 was using qv_sat, which is gone."
jgfouca Jan 19, 2024
5c757a2
Restore backwards compatible qv_sat
jgfouca Jan 19, 2024
8cd5447
Change EAMxx site name for docs
rljacob Jan 19, 2024
caa81ca
Add EAMxx component to master list
rljacob Jan 19, 2024
f370642
Update PAM for build fixes
brhillman Jan 23, 2024
09da5ec
Merge remote-tracking branch 'abag/abagusetty/yakl-submodule-update' …
jgfouca Jan 24, 2024
95c0a58
Another update to PAM to fix build errors on mappy
jgfouca Jan 24, 2024
373ebcd
Bring in latest PAM branch
jgfouca Jan 24, 2024
2140ebc
Increase gator pool size for pm-cpu
jgfouca Jan 25, 2024
1708b46
Set pam subm to latest master
jgfouca Jan 25, 2024
0c8b36d
Fix Homme Cmake, EKAT subm update changed the EkatBuildKokkos module
jgfouca Jan 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
13 changes: 11 additions & 2 deletions .github/workflows/e3sm-gh-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,31 @@ concurrency:

jobs:
Build-and-Deploy-docs:
if: ${{ github.event.repository.name != 'scream' }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
show-progress: false
fetch-depth: 0 # Needed, or else gh-pages won't be fetched, and push rejected
submodules: false # speeds up clone and not building anything in submodules
# TODO: git rid of dependency on CIME
# TODO: another option to investigate is a sparse checkout.
# In the scream repo, all other components do not need to be checked out.
# And even in the upstream, we mainly need only components/xyz/docs (and a few more places).
submodules: true
- name: Show action trigger
run: echo "= The job was automatically triggered by a ${{github.event_name}} event."
run: echo "= The job was automatically triggered by a ${{github.event_name}} event on repo ${{github.event.repository.name}}."
- name: Set up Python 3.10
uses: actions/[email protected]
with:
python-version: "3.10"
- name: Install python deps
run: python3 -m pip install mkdocs-material pymdown-extensions mkdocs-monorepo-plugin mdutils mkdocs-bibtex
# build every time (PR or push to master)
- name: Generate EAMxx params docs
working-directory: components/eamxx/scripts
run: |
./eamxx-params-docs-autogen
- name: Build
run: mkdocs build --strict --verbose
# Only deploy to the main github page when there is a push to master
Expand Down
88 changes: 88 additions & 0 deletions .github/workflows/eamxx-gh-pages.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
# This workflow aims to automatically rebuild eamxx documentation
# every time the master branch is updated on github and within every PR

name: EAMxx Docs

on:
# Runs every time master branch is updated
push:
branches: [ master ]
# Only if docs-related files are touched
paths:
- components/eamxx/mkdocs.yml
- components/eamxx/docs/**
- components/eamxx/cime_config/namelist_defaults_scream.xml
# Runs every time a PR is open against master
pull_request:
branches: [ master ]
# Only if docs-related files are touched
paths:
- components/eamxx/mkdocs.yml
- components/eamxx/docs/**
- components/eamxx/cime_config/namelist_defaults_scream.xml

label:
types:
- created

workflow_dispatch:

concurrency:
# Prevent 2+ copies of this workflow from running concurrently
group: eamxx-docs-action

jobs:

eamxx-docs:
if: ${{ github.event.repository.name == 'scream' }}
runs-on: ubuntu-latest

steps:
- name: Check out the repository
uses: actions/checkout@v4
with:
show-progress: false
# TODO: git rid of dependency on CIME
# TODO: another option to investigate is a sparse checkout.
# In the scream repo, all other components do not need to be checked out.
# And even in the upstream, we mainly need only components/xyz/docs (and a few more places).
submodules: true

- name: Show action trigger
run: |
echo "= The job was automatically triggered by a ${{github.event_name}} event."

- name: Set up Python 3.10
uses: actions/[email protected]
with:
python-version: "3.10"

- name: Install Python deps
run: |
pip install mkdocs pymdown-extensions mkdocs-material mdutils

- name: Generate EAMxx params docs
working-directory: components/eamxx/scripts
run: |
./eamxx-params-docs-autogen

- name: Build docs
working-directory: components/eamxx
run: |
mkdocs build --strict --verbose

# only deploy to the main github page when there is a push to master
- if: ${{ github.event_name == 'push' }}
name: GitHub Pages action
uses: JamesIves/github-pages-deploy-action@v4
with:
# Do not remove existing pr-preview pages
clean-exclude: pr-preview
folder: ./components/eamxx/site

# If it's a PR from within the same repo, deploy to a preview page
- if: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository }}
name: Preview docs
uses: rossjrw/pr-preview-action@v1
with:
source-dir: components/eamxx/site/
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,8 @@ site

# Ignore emacs backup files
*~

# Ignore mkdocs site-generated files in eamxx
components/eamxx/site/*
# Ignore auto-generated eamxx_params.md file
components/eamxx/docs/common/eamxx_params.md
10 changes: 9 additions & 1 deletion cime_config/allactive/config_compsets.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
TIME_ATM[%phys]_LND[%phys]_ICE[%phys]_OCN[%phys]_ROF[%phys]_GLC[%phys]_WAV[%phys][_ESP%phys][_BGC%phys]
Where for the EAM specific compsets below the following is supported
TIME = Time period (e.g. 2000, HIST, RCP8...)
ATM = [EAM, SATM, SCREAM]
ATM = [EAM, EAMXX, SATM, SCREAM]
LND = [ELM, SLND]
ICE = [MPASSI, CICE, DICE, SICE]
OCN = [MPASO, DOCN, SOCN]
Expand Down Expand Up @@ -396,6 +396,14 @@
<lname>1850_EAM%CMIP6_ELM%SPBC_MPASSI_MPASO_MOSART_MALI%STATIC_SWAV</lname>
</compset>

<!-- EAMXX fully coupled compset -->

<compset>
<alias>WCYCLXX2010</alias>
<lname>2010_EAMXX_ELM%SPBC_MPASSI_MPASO_MOSART_SGLC_SWAV</lname>
</compset>


<!-- OCN + CICE + GLC Only Compsets -->
<compset>
<alias>MPAS_LISIO_TEST</alias>
Expand Down
47 changes: 47 additions & 0 deletions cime_config/allactive/config_pesall.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1853,6 +1853,29 @@
</nthrds>
</pes>
</mach>
<mach name="frontier-scream-gpu">
<pes compset="any" pesize="any">
<comment>"crusher-gpu-scream ne30np4 and ne30np4.pg2"</comment>
<ntasks>
<ntasks_atm>-2</ntasks_atm>
<ntasks_lnd>-2</ntasks_lnd>
<ntasks_rof>-2</ntasks_rof>
<ntasks_ice>-2</ntasks_ice>
<ntasks_ocn>-2</ntasks_ocn>
<ntasks_glc>-2</ntasks_glc>
<ntasks_wav>-2</ntasks_wav>
<ntasks_cpl>-2</ntasks_cpl>
</ntasks>
<nthrds>
<nthrds_atm>1</nthrds_atm>
<nthrds_lnd>7</nthrds_lnd>
<nthrds_rof>1</nthrds_rof>
<nthrds_ice>1</nthrds_ice>
<nthrds_ocn>1</nthrds_ocn>
<nthrds_cpl>1</nthrds_cpl>
</nthrds>
</pes>
</mach>
</grid>
<grid name="a%ne0np4_northamericax4v1.pg2_l%.+_oi%WC14to60E2r3">
<mach name="compy">
Expand Down Expand Up @@ -2336,6 +2359,30 @@
</nthrds>
</pes>
</mach>
<mach name="frontier-scream-gpu">
<pes compset="any" pesize="any">
<MAX_MPITASKS_PER_NODE>8</MAX_MPITASKS_PER_NODE>
<MAX_TASKS_PER_NODE>56</MAX_TASKS_PER_NODE>
<ntasks>
<ntasks_atm>-6</ntasks_atm>
<ntasks_lnd>-6</ntasks_lnd>
<ntasks_rof>-6</ntasks_rof>
<ntasks_ice>-6</ntasks_ice>
<ntasks_ocn>-6</ntasks_ocn>
<ntasks_glc>-6</ntasks_glc>
<ntasks_wav>-6</ntasks_wav>
<ntasks_cpl>-6</ntasks_cpl>
</ntasks>
<nthrds>
<nthrds_atm>1</nthrds_atm>
<nthrds_lnd>7</nthrds_lnd>
<nthrds_rof>1</nthrds_rof>
<nthrds_ice>1</nthrds_ice>
<nthrds_ocn>1</nthrds_ocn>
<nthrds_cpl>1</nthrds_cpl>
</nthrds>
</pes>
</mach>
<mach name="pm-gpu|muller">
<pes compset="any" pesize="any">
<MAX_MPITASKS_PER_NODE>4</MAX_MPITASKS_PER_NODE>
Expand Down
1 change: 1 addition & 0 deletions cime_config/config_files.xml
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@
<value component="satm" >$SRCROOT/components/stub_comps/satm</value>
<value component="xatm" >$SRCROOT/components/xcpl_comps/xatm</value>
<value component="eam" >$SRCROOT/components/eam/</value>
<value component="eamxx" >$SRCROOT/components/eamxx/</value>
<value component="scream" >$SRCROOT/components/eamxx/</value>
</values>
<group>case_comps</group>
Expand Down
20 changes: 20 additions & 0 deletions cime_config/config_grids.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,16 @@
<mask>oEC60to30v3</mask>
</model_grid>

<model_grid alias="ne120pg2_EC30to60E2r2">
<grid name="atm">ne120np4.pg2</grid>
<grid name="lnd">ne120np4.pg2</grid>
<grid name="ocnice">EC30to60E2r2</grid>
<grid name="rof">null</grid>
<grid name="glc">null</grid>
<grid name="wav">null</grid>
<mask>EC30to60E2r2</mask>
</model_grid>

<model_grid alias="ne120pg2_r05_EC30to60E2r2">
<grid name="atm">ne120np4.pg2</grid>
<grid name="lnd">r05</grid>
Expand Down Expand Up @@ -1486,6 +1496,16 @@
<mask>oRRS18to6v3</mask>
</model_grid>

<model_grid alias="ne256pg2_oRRS18to6v3">
<grid name="atm">ne256np4.pg2</grid>
<grid name="lnd">ne256np4.pg2</grid>
<grid name="ocnice">oRRS18to6v3</grid>
<grid name="rof">null</grid>
<grid name="glc">null</grid>
<grid name="wav">null</grid>
<mask>oRRS18to6v3</mask>
</model_grid>

<model_grid alias="ne256pg2_r0125_oRRS18to6v3">
<grid name="atm">ne256np4.pg2</grid>
<grid name="lnd">r0125</grid>
Expand Down
43 changes: 43 additions & 0 deletions cime_config/machines/Depends.frontier-gpu.crayclang.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
set(CICE_F90
ice_FY.F90
ice_aerosol.F90
ice_age.F90
ice_atmo.F90
ice_blocks.F90
ice_calendar.F90
ice_diagnostics.F90
ice_distribution.F90
ice_domain.F90
ice_domain_size.F90
ice_dyn_evp.F90
ice_fileunits.F90
ice_flux.F90
ice_forcing.F90
ice_grid.F90
ice_history.F90
ice_history_fields.F90
ice_init.F90
ice_itd.F90
ice_kinds_mod.F90
ice_lvl.F90
ice_mechred.F90
ice_meltpond.F90
ice_ocean.F90
ice_orbital.F90
ice_probability.F90
ice_probability_tools.F90
ice_read_write.F90
ice_restoring.F90
ice_shortwave.F90
ice_spacecurve.F90
ice_state.F90
ice_step_mod.F90
ice_therm_itd.F90
ice_therm_vertical.F90
ice_transport_driver.F90
ice_transport_remap.F90
ice_work.F90)

foreach(ITEM IN LISTS CICE_F90)
e3sm_add_flags("cice/src/source/${ITEM}" "-O0")
endforeach()
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
set(REDOPT
../driver-mct/main/seq_io_mod.F90
elm/src/biogeophys/BandDiagonalMod.F90)

if (NOT DEBUG)
foreach(ITEM IN LISTS REDOPT)
e3sm_add_flags("${ITEM}" "-O1 -g")
endforeach()
endif()

set(CICE_F90
ice_FY.F90
ice_aerosol.F90
ice_age.F90
ice_atmo.F90
ice_blocks.F90
ice_calendar.F90
ice_diagnostics.F90
ice_distribution.F90
ice_domain.F90
ice_domain_size.F90
ice_dyn_evp.F90
ice_fileunits.F90
ice_flux.F90
ice_forcing.F90
ice_grid.F90
ice_history.F90
ice_history_fields.F90
ice_init.F90
ice_itd.F90
ice_kinds_mod.F90
ice_lvl.F90
ice_mechred.F90
ice_meltpond.F90
ice_ocean.F90
ice_orbital.F90
ice_probability.F90
ice_probability_tools.F90
ice_read_write.F90
ice_restoring.F90
ice_shortwave.F90
ice_spacecurve.F90
ice_state.F90
ice_step_mod.F90
ice_therm_itd.F90
ice_therm_vertical.F90
ice_transport_driver.F90
ice_transport_remap.F90
ice_work.F90)

foreach(ITEM IN LISTS CICE_F90)
e3sm_add_flags("cice/src/source/${ITEM}" "-O0")
endforeach()
7 changes: 4 additions & 3 deletions cime_config/machines/cmake_macros/crayclang-scream.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,17 @@ string(APPEND CMAKE_Fortran_FLAGS_DEBUG " -O0 -g")
string(APPEND CMAKE_CXX_FLAGS_DEBUG " -O0 -g")
string(APPEND CPPDEFS_DEBUG " -DYAKL_DEBUG")
string(APPEND CPPDEFS " -DFORTRANUNDERSCORE -DNO_R16 -DCPRCRAY")
# -em (default) generates MODULENAME.mod files
string(APPEND CMAKE_Fortran_FLAGS " -f free -N 255 -h byteswapio -em")
# -em -ef generates modulename.mod files (lowercase), which we must have
string(APPEND CMAKE_Fortran_FLAGS " -f free -em -ef")
if (NOT compile_threaded)
# -M1077 flag used to suppress message about OpenMP directives
# that are ignored for non-threaded builds. (-h omp inactive)
# Details: `explain ftn-1077`
string(APPEND CMAKE_Fortran_FLAGS " -M1077")
endif()
set(HAS_F2008_CONTIGUOUS "TRUE")
string(APPEND CMAKE_EXE_LINKER_FLAGS " -Wl,--allow-multiple-definition -h byteswapio")
string(APPEND CMAKE_EXE_LINKER_FLAGS " -Wl,--allow-multiple-definition -ldl")
set(E3SM_LINK_WITH_FORTRAN "TRUE")
set(MPICC "cc")
set(MPICXX "CC")
set(MPIFC "ftn")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@ if (COMP_NAME STREQUAL elm)
string(APPEND CMAKE_Fortran_FLAGS " -hfp0")
endif()
string(APPEND CMAKE_Fortran_FLAGS " -hipa0 -hzero")
string(APPEND CMAKE_Fortran_FLAGS " -em -ef")

set(PIO_FILESYSTEM_HINTS "gpfs")
Loading
Loading