Fixes ELM namelist for with active FAN model #6151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `use_fan = .true.` in `user_nl_elm`, add settings for the FAN model in `lnd_in`.
|
rljacob
reviewed
Jan 17, 2024
| if( $nl_flags->{'use_fan'} eq ".true." ) { | ||
| my $var = "use_fan"; | ||
| my $val = $nl->get_value($var); | ||
| if( $val eq ".true." ) { |
There was a problem hiding this comment.
Yes. The information about use_fan was being extracted from the wrong data structure.
bbye
approved these changes
Jan 17, 2024
|
Will this change namelists for the fan test? |
rljacob
added a commit
that referenced
this pull request
Jan 18, 2024
If use_fan = .true. in user_nl_elm, add settings for the FAN model in lnd_in. Fixes #6152 [BFB]
|
use_fan = .true. now shows up in the elm-fan test. And that test passes and no longer has a namelist diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
use_fan = .true.inuser_nl_elm, add settings for the FAN model inlnd_in.Fixes #6152
[BFB]