Fixing a bug causing floating-point error in RtmMod.F90 #6146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wo way coupling is on
ndkeen
approved these changes
Jan 11, 2024
donghuix
approved these changes
Jan 11, 2024
|
@liho745 is this BFB or non-BFB ? |
|
I'd say it is BFB, but did not run a full developer test since it is only a
bug fix.
…On Thu, Jan 18, 2024 at 11:28 PM Robert Jacob ***@***.***> wrote:
@liho745 <https://github.com/liho745> is this BFB or non-BFB ?
—
Reply to this email directly, view it on GitHub
<#6146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC5QWBRM5MG4M7IL3IYLIJ3YPH767AVCNFSM6AAAAABBVWMVZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJZG44TINBTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@liho745 you should see if its BFB. You could just run one test. |
@rljacob Three MOSART related tests all passed BFB on Compy: ERS.MOS_USRDAT.RMOSGPCC.compy_intel.mosart-mos_usrdat; ERS.r05_r05.RMOSGPCC.compy_intel.mosart-gpcc_1972; SMS.MOS_USRDAT.RMOSGPCC.compy_intel.mosart-unstructure. So, the bug fix should be BFB. |
|
great! @bishtgautam you can start merging this. |
|
I re-merged another MOSART PR (#6092) today. I will merge this PR tomorrow, provided nightly tests look good tomorrow. |
bishtgautam
added a commit
that referenced
this pull request
Feb 2, 2024
A bug in RtmMod.F90 has been causing a floating-point error, related to Tunit%rlen, when the land-river two-way coupling is invoked. This PR fixes that bug based on a branch off the commit, 417920b, where the bug was introduced into the master. [BFB] Fixes #5540
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug in RtmMod.F90 has been causing a floating-point error, related to Tunit%rlen,
when the land-river two-way coupling is invoked. This PR fixes that bug based on
a branch off the commit, 417920b, where the bug was introduced into the master.
[BFB]
Fixes #5540