Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes an ELM setup error related to FAN model #6142

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fixes an ELM setup error related to FAN model #6142

merged 1 commit into from
Jan 12, 2024

Conversation

bishtgautam
Copy link
Contributor

@bishtgautam bishtgautam commented Jan 6, 2024 •
edited by rljacob
Loading

Changes the check to determine if the FAN model is active.

Fixes #6141
[BFB]
[NML]

@bishtgautam
Fixes an ELM setup error related to FAN model
cfd410a 
Changes the check to determine if the FAN model is active.

Fixes #6141
[BFB]
@bishtgautam bishtgautam requested a review from bbye January 6, 2024 04:26
@bishtgautam bishtgautam added Land bug fix PR BFB PR leaves answers BFB labels Jan 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

PR Preview Action v1.4.6
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6142/
on branch gh-pages at 2024-01-06 04:27 UTC

@bishtgautam bishtgautam mentioned this pull request Jan 6, 2024
Merged
@bishtgautam bishtgautam requested a review from wlin7 January 6, 2024 04:29
@rljacob rljacob added this to the v3.0.0-rc milestone Jan 8, 2024
rljacob added a commit that referenced this pull request Jan 11, 2024
@rljacob
Merge branch 'bishtgautam/lnd/fan-setup' into next (PR #6142)
b256359 
Changes the check to determine if the FAN model is active.

Fixes #6141
[BFB]
@rljacob rljacob merged commit b633fd5 into master Jan 12, 2024
3 checks passed
@rljacob rljacob deleted the bishtgautam/lnd/fan-setup branch January 12, 2024 21:03
@rljacob rljacob added the NML label Jan 16, 2024
@rljacob
Copy link
Member

rljacob commented Jan 16, 2024

I merged this to master without realizing it made namelist changes (wasn't labeled. Fixed). And one of those namelist changes was wrong. This PR turns off FAN for the FAN test:

SMS_Ly2_P1x1.1x1_smallvilleIA.IELMCNCROP.chrysalis_intel.elm-fan NML DIFF:
Comparison failed between '/lcrc/group/e3sm2/e3smtest/scratch/chrys/J/SMS_Ly2_P1x1.1x1_smallvilleIA.IELMCNCROP.chrysalis_intel.elm-fan.C.JMasterIntegration20240115_035742/CaseDocs/lnd_in' with '/lcrc/group/e3sm2/baselines/chrys/intel/master/SMS_Ly2_P1x1.1x1_smallvilleIA.IELMCNCROP.chrysalis_intel.elm-fan/CaseDocs/lnd_in'
Missing namelist: fan_nml

@bishtgautam
Copy link
Contributor Author

Let me work on fixing this.

@bishtgautam bishtgautam mentioned this pull request Jan 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbye bbye bbye approved these changes

@wlin7 wlin7 Awaiting requested review from wlin7

Assignees

@rljacob rljacob

Labels
BFB PR leaves answers BFB bug fix PR Land NML
Projects
None yet
Milestone
v3.0.0-rc
Development

Successfully merging this pull request may close these issues.

ELM set fails with FAN-related error
4 participants
@bishtgautam @rljacob @bbye @peterdschwartz