-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ECwISC30to60E3r2 ocean and sea ice mesh #6099
Remove ECwISC30to60E3r2 ocean and sea ice mesh #6099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by visual inspection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving by visual inspection
This version of the mesh had a bug in the `landIceMask` field and will be replaced with one of the IcoswISC30E3r* meshes.
c1428f9
to
c76e37c
Compare
@jonbob, I rebased to fix conflicts. I believe this is ready to test and merge when there's a chance. |
Remove ECwISC30to60E3r2 ocean and sea ice mesh This version of the mesh had a bug in the landIceMask field and will be replaced with one of the IcoswISC30E3r* meshes. This effectively reverts #5927 [BFB]
Passes:
merged to next |
merged to master @rljacob - what should we do with all the new files we have on the inputdata repo, now that this mesh is removed from e3sm? |
Since they weren't in an official release, and you don't want them used, go ahead and delete them. Where they ever referenced in an out-of-the-box case on master? |
They were used by some of the Critical Path runs, but I don't think by anyone else |
we also have files for some of the meshes we tried and did not merge for full e3sm support on:
We could cleanup those as well? |
But a lot of the critical path settings were made with run scripts. Can I create_newcase from a hash on master that uses those files? @golaz should also say if they should be kept. |
Yes, there was a period when you could run create_newcase on master that would use this mesh and therefore need these files |
I did quite a few runs using this grid and I'd like to perform more analysis on them. I don't plan to run with it anymore, but would like access to the grid file. I can make my own copy, if necessary. |
This version of the mesh had a bug in the
landIceMask
field and will be replaced with one of the IcoswISC30E3r* meshes.This effectively reverts #5927