Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ECwISC30to60E3r2 ocean and sea ice mesh #6099

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Dec 4, 2023

This version of the mesh had a bug in the landIceMask field and will be replaced with one of the IcoswISC30E3r* meshes.

This effectively reverts #5927

Copy link
Contributor

@proteanplanet proteanplanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by visual inspection.

Copy link
Contributor

@vanroekel vanroekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving by visual inspection

This version of the mesh had a bug in the `landIceMask` field
and will be replaced with one of the IcoswISC30E3r* meshes.
@xylar xylar force-pushed the mesh/remove-ecwisc30to60e3r2 branch from c1428f9 to c76e37c Compare December 13, 2023 16:48
@xylar
Copy link
Contributor Author

xylar commented Dec 13, 2023

@jonbob, I rebased to fix conflicts. I believe this is ready to test and merge when there's a chance.

jonbob added a commit that referenced this pull request Dec 13, 2023
Remove ECwISC30to60E3r2 ocean and sea ice mesh

This version of the mesh had a bug in the landIceMask field and will be
replaced with one of the IcoswISC30E3r* meshes.

This effectively reverts #5927

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Dec 13, 2023

Passes:

  • ERS_Ld5.T62_oQU120.CMPASO-NYF.chrysalis_intel
  • SMS_Ld1.ne30pg2_EC30to60E2r2.WCYCL1850.chrysalis_intel.allactive-wcprod_1850

merged to next

@jonbob jonbob merged commit 84d0c03 into E3SM-Project:master Dec 14, 2023
3 checks passed
@jonbob
Copy link
Contributor

jonbob commented Dec 14, 2023

merged to master

@rljacob - what should we do with all the new files we have on the inputdata repo, now that this mesh is removed from e3sm?

@rljacob
Copy link
Member

rljacob commented Dec 14, 2023

Since they weren't in an official release, and you don't want them used, go ahead and delete them. Where they ever referenced in an out-of-the-box case on master?

@jonbob
Copy link
Contributor

jonbob commented Dec 14, 2023

They were used by some of the Critical Path runs, but I don't think by anyone else

@jonbob
Copy link
Contributor

jonbob commented Dec 14, 2023

we also have files for some of the meshes we tried and did not merge for full e3sm support on:

/lcrc/group/e3sm/data/inputdata

We could cleanup those as well?

@rljacob
Copy link
Member

rljacob commented Dec 14, 2023

But a lot of the critical path settings were made with run scripts. Can I create_newcase from a hash on master that uses those files?

@golaz should also say if they should be kept.

@jonbob
Copy link
Contributor

jonbob commented Dec 14, 2023

Yes, there was a period when you could run create_newcase on master that would use this mesh and therefore need these files

@maltrud
Copy link
Contributor

maltrud commented Dec 14, 2023

I did quite a few runs using this grid and I'd like to perform more analysis on them. I don't plan to run with it anymore, but would like access to the grid file. I can make my own copy, if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB mpas-ocean mpas-seaice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants