Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default config_Redi_min_layers_diag_terms to 0 #6077

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

jonbob
Copy link
Contributor

@jonbob jonbob commented Nov 20, 2023

Changes a single default setting for config_Redi_min_layers_diag_terms from 6 to 0. This has otherwise been set in user_nl_mpaso by run scripts during coupled model testing.

[NML]
[non-BFB] for some ocean meshes

@jonbob jonbob requested a review from vanroekel November 20, 2023 21:50
@jonbob jonbob self-assigned this Nov 20, 2023
Copy link

PR Preview Action v1.4.4
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6077/
on branch gh-pages at 2023-11-20 21:51 UTC

Copy link
Contributor

@vanroekel vanroekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving by visual inspection. This is the expected default for v3

@wlin7 wlin7 added this to the v3.0beta02 milestone Nov 22, 2023
@jonbob jonbob added NML non-BFB PR makes roundoff changes to answers. labels Nov 27, 2023
jonbob added a commit that referenced this pull request Nov 27, 2023
…(PR #6077)

Change default config_Redi_min_layers_diag_terms to 0

Changes a single default setting for config_Redi_min_layers_diag_terms
from 6 to 0. This has otherwise been set in user_nl_mpaso by run scripts
during coupled model testing.

[NML]
[non-BFB]
@jonbob
Copy link
Contributor Author

jonbob commented Nov 27, 2023

testing verifies that this PR has NML DIFFs and is only non-BFB for some but not all ocean meshes:

  • FAIL ERS_Ld5.T62_oQU120.CMPASO-NYF.chrysalis_intel NLCOMP
  • PASS ERS_Ld5.T62_oQU120.CMPASO-NYF.chrysalis_intel BASELINE master:
  • FAIL PET_Ln9_PS.ne30pg2_EC30to60E2r2.WCYCL1850.chrysalis_intel.allactive-mach-pet NLCOMP
  • FAIL PET_Ln9_PS.ne30pg2_EC30to60E2r2.WCYCL1850.chrysalis_intel.allactive-mach-pet BASELINE master: DIFF

merged to next

@jonbob jonbob merged commit 839d1cf into master Nov 28, 2023
2 checks passed
@jonbob jonbob deleted the jonbob/mpaso/change-default-redi-min-layers branch November 28, 2023 18:01
@jonbob
Copy link
Contributor Author

jonbob commented Nov 28, 2023

merged to master and blessed expected NML and regular DIFFs -- except for mappy next, which has not yet reported

@jonbob
Copy link
Contributor Author

jonbob commented Nov 29, 2023

mappy next reported and DIFFs there have been blessed as well

xylar added a commit to xylar/compass that referenced this pull request Dec 3, 2023
This merge updates the E3SM-Project submodule from [894b5b2](https://github.com/E3SM-Project/E3SM/tree/894b5b2) to [5d5f15c](https://github.com/E3SM-Project/E3SM/tree/5d5f15c).

This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list):
- [ ]  (ocn) E3SM-Project/E3SM#5945
- [ ]  (ocn) E3SM-Project/E3SM#5946
- [ ]  (ocn) E3SM-Project/E3SM#5947
- [ ]  (ocn) E3SM-Project/E3SM#5999
- [ ]  (ocn) E3SM-Project/E3SM#6037
- [ ]  (ocn) E3SM-Project/E3SM#5989
- [ ]  (ocn) E3SM-Project/E3SM#6035
- [ ]  (ocn) E3SM-Project/E3SM#6077
xylar added a commit to xylar/compass that referenced this pull request Dec 3, 2023
xylar added a commit to xylar/compass that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mpas-ocean NML non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants