Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set parameters to wrap up v3alpha03 configuration #5970

Merged
merged 7 commits into from
Oct 19, 2023
Merged

Conversation

wlin7
Copy link
Contributor

@wlin7 wlin7 commented Oct 4, 2023

To set default the extra parameters for atm and lnd used by v3alpha03 configuration.
The merge of this PR should create a state ready for tagging v3alpha03.

Land surface data for WCYCL config are updated to enable subgrid topographic
radiative parameterization (TOP). The surfdata files for simyr 1850 and 2010 are fully
ready for ne30pg2 and r05 grids. Workaround are applied for F2010 ne4, ne4pg2, ne11
grids, 1850 NARRM, and SSP370 and SSP585 ne30pg2 grid, with placeholder for
TOP-related variables. The TOP developers will update these files.

Land initial files for several wcprod F2010 and F20R tests with older trigrid are disabled.
The trigrid for the tests will be updated at a later time along with new initial files.

[non-BFB] for all F and B-cases.
[NML] extra default namelist variables in atm_in and lnd_in along with some update on input files


The change on elm to enable use_top_solar_rad for water cycle production config to be added.

#5252 is temporarily reverted in order for the target v3alpha03 tag to reproduce coupled v3alpha03 simulation. It will be restored after this and a similar PR for wrapping up v3alpha04 config are merged. With proper reproducibility tests done, all these PRs (including revert the revert of #5252) should happen on the same day, to avoid repeated diffs for the same cime tests.

wlin7 and others added 4 commits October 3, 2023 13:44
The ELM topographic parameterization for solar radiation (`use_top_solar_rad`),
can now be set on if the long compset name uses `_ELM%SPTOP_`.
@wlin7
Copy link
Contributor Author

wlin7 commented Oct 5, 2023

@bishtgautam , thank you for implementing the mechanism for setting the option for solar_rad scheme. Turning the TOP scheme on/off becomes very easy now. It has been tested with either option, and all work as intended.

@wlin7 wlin7 changed the title WIP: Set parameters to wrap up v3alpha03 configuration Set parameters to wrap up v3alpha03 configuration Oct 5, 2023
@wlin7
Copy link
Contributor Author

wlin7 commented Oct 5, 2023

Running a v3alpha03 simulation to verify reproducibility. While lght_no_prd_factor sets to 5.0 for existing v3alpha03.F2010 simulation, it was unintentionally set to 1.0 in v3alpha03.piControl simulation. May consider to use 1.0 as default for the v3alpha03 tag.

@tangq
Copy link
Contributor

tangq commented Oct 5, 2023

Hi @wlin7 , it would better to set lght_no_prd_factor = 5.0 for historical and AMIP runs, because it mainly affects tropospheric ozone and during pre-industrial periods (piControl) ozone precursor emissions are low and hence setting it to 1.0 or 5.0 won't make a big difference. We really need to verify the ozone time series when the lightning NOx emission is in the reasonable range in the historical and AMIP runs. If keeping it to the wrong 1.0 value, we won't be able to do that.

In conclusion, I strongly recommend we use lght_no_prd_factor = 5.0 for other v3alpha03 tests.

Running a v3alpha03 simulation to verify reproducibility. While lght_no_prd_factor sets to 5.0 for existing v3alpha03.F2010 simulation, it was unintentionally set to 1.0 in v3alpha03.piControl simulation. May consider to use 1.0 as default for the v3alpha03 tag.

@wlin7
Copy link
Contributor Author

wlin7 commented Oct 8, 2023

@tangq , thanks for the comments. lght_no_prd_factor = 5.0 was intended for v3alpha03 but was not set in the piControl simulation. No problem to keep the changes in this PR as is.

With the current PR state, the v3alpha03-tag.F2010 run script reproduced the 20230917.v3alpha03.F2010 simulation. that psecified additional tuning parameters in user_nl. Likewise, the v3alpha04-tag.piControl run script with this PR, except still specifying lght_no_prd_factor = 1.0 in run script, reproduced the 20230914.v3alpha03.piControl simulation.

The above tests confirmed after merging this branch, which also reverted #5252, the master state is suitable for v3alpha03 tag.

@wlin7 wlin7 added this to the v3.0alpha03 milestone Oct 8, 2023
@wlin7 wlin7 added Atmosphere Land non-BFB PR makes roundoff changes to answers. labels Oct 8, 2023
@wlin7 wlin7 requested review from rljacob and golaz October 10, 2023 18:50
@wlin7
Copy link
Contributor Author

wlin7 commented Oct 10, 2023

@rljacob , the plan is to merge this, #5973, and another one on top of #5973 to revert the revert of @5252. These should provide the states for creating v3alpha03, v3alpha04 tags, and restoring the current state of master (that contains NBFB changes from #5252). The end state is v3alpha04 config + changes from #5252. Each standalone would cause NBFB w.r.t to baselines, but they are not really new NBFB. To avoid repeated diffs on dashboard, we can merge them on a same day.

@wlin7
Copy link
Contributor Author

wlin7 commented Oct 11, 2023

This PR is not ready. Due to enabling of TOP (subgrid topographic solar radiation parameterization) scheme, fsurdat are needed for all grids (in particurlar non production grids, e.g., ne4, ne11). Otherwise, the test would fail with ENDRUN:surfrd_get_topo_for_solar_rad ERROR: STDEV_ELEV NOT on fsurdat file.

New fsurdat for the following grids are needed now ne4_oQU240, ne11_oQU240, ne4pg2_oQU480, northamericax4v1pg2_WC14to60E2r3. May also need it for ne4_ne4 down the road. wcprod has two tests using ne30pg2_r05_oECv3, which can be replaced with v3alpha03 ne30pg2_r05_EC30to60E2r2.

Working on it with TOP developer.

Surface datasets dataset for following resolutions have been updated to include
new fields needed for TOP parameterization in ELM:
- ne4_oQU240
- ne4pg2_oQU480
- northamericax4v1pg2_WC14to60E2r3
@github-actions
Copy link

github-actions bot commented Oct 12, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-5970/
on branch gh-pages at 2023-10-18 16:43 UTC

@wlin7
Copy link
Contributor Author

wlin7 commented Oct 18, 2023

e3sm_atm_integration and wcprod test suites following latest commits all returned expected diff, (except for existing FAIL).

@wlin7 wlin7 added the inputdata Changes affecting inputdata collection on blues label Oct 18, 2023
wlin7 added a commit that referenced this pull request Oct 18, 2023
Set parameters to wrap up v3alpha03 configuration

To set default the extra parameters for atm and lnd used by v3alpha03
configuration.  The merge of this PR should create a state ready for
tagging v3alpha03.

Land surface data for WCYCL config are updated to enable subgrid topographic
radiative parameterization (TOP). The surfdata files for simyr 1850 and 2010
are fully ready for ne30pg2 and r05 grids. Workaround are applied for F2010
ne4, ne4pg2, ne11 grids, 1850 NARRM, and SSP370 and SSP585 ne30pg2 grid, with
placeholder for TOP-related variables. The TOP developers will update these files.

Land initial files for several wcprod F2010 and F20R tests with older trigrid
are disabled.  The trigrid for the tests will be updated at a later time along
with new initial files.

[non-BFB] for all F and B-cases.
[NML] extra default namelist variables in atm_in and lnd_in along with some
      update on input files
@wlin7
Copy link
Contributor Author

wlin7 commented Oct 18, 2023

Merged to next.

wlin7 added a commit that referenced this pull request Oct 18, 2023
Restore the fix in PR 5252

The fix was reverted via #5970 for creating v3alpha03 tag.

[NBFB] relative to the state before this revert of revert.
@wlin7 wlin7 merged commit bfaadd3 into master Oct 19, 2023
2 checks passed
@wlin7 wlin7 deleted the wlin/wrapup_v3alpha03 branch October 19, 2023 15:49
@wlin7
Copy link
Contributor Author

wlin7 commented Oct 19, 2023

Merged to master.

wlin7 added a commit that referenced this pull request Oct 19, 2023
Restore the fix in PR 5252

The fix was reverted via #5970 for creating v3alpha03 tag.

[NBFB] relative to the state before this revert of revert.
@wlin7
Copy link
Contributor Author

wlin7 commented Oct 19, 2023

Notes on a chrysalis' diffs

F2010-MMF2 due to no space on disk during build
ne4_oQU240.WCYCL1850NS needs a new fsurdat with TOP (to be updated)
ne11_oQU240.WCYCL1850NS has NaNs in reprosum_calc

ne30_oECv3.F2010 tests on gpc12 failing, need new surfdata for ne30np4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Atmosphere Coupled Model inputdata Changes affecting inputdata collection on blues Land mpas-seaice non-BFB PR makes roundoff changes to answers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants