-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set parameters to wrap up v3alpha03 configuration #5970
Conversation
The ELM topographic parameterization for solar radiation (`use_top_solar_rad`), can now be set on if the long compset name uses `_ELM%SPTOP_`.
@bishtgautam , thank you for implementing the mechanism for setting the option for solar_rad scheme. Turning the TOP scheme on/off becomes very easy now. It has been tested with either option, and all work as intended. |
Running a v3alpha03 simulation to verify reproducibility. While |
Hi @wlin7 , it would better to set In conclusion, I strongly recommend we use
|
@tangq , thanks for the comments. With the current PR state, the v3alpha03-tag.F2010 run script reproduced the 20230917.v3alpha03.F2010 simulation. that psecified additional tuning parameters in user_nl. Likewise, the v3alpha04-tag.piControl run script with this PR, except still specifying The above tests confirmed after merging this branch, which also reverted #5252, the master state is suitable for v3alpha03 tag. |
@rljacob , the plan is to merge this, #5973, and another one on top of #5973 to revert the revert of @5252. These should provide the states for creating v3alpha03, v3alpha04 tags, and restoring the current state of master (that contains NBFB changes from #5252). The end state is v3alpha04 config + changes from #5252. Each standalone would cause NBFB w.r.t to baselines, but they are not really new NBFB. To avoid repeated diffs on dashboard, we can merge them on a same day. |
This PR is not ready. Due to enabling of TOP (subgrid topographic solar radiation parameterization) scheme, fsurdat are needed for all grids (in particurlar non production grids, e.g., ne4, ne11). Otherwise, the test would fail with New fsurdat for the following grids are needed now Working on it with TOP developer. |
Surface datasets dataset for following resolutions have been updated to include new fields needed for TOP parameterization in ELM: - ne4_oQU240 - ne4pg2_oQU480 - northamericax4v1pg2_WC14to60E2r3
|
e3sm_atm_integration and wcprod test suites following latest commits all returned expected diff, (except for existing FAIL). |
Set parameters to wrap up v3alpha03 configuration To set default the extra parameters for atm and lnd used by v3alpha03 configuration. The merge of this PR should create a state ready for tagging v3alpha03. Land surface data for WCYCL config are updated to enable subgrid topographic radiative parameterization (TOP). The surfdata files for simyr 1850 and 2010 are fully ready for ne30pg2 and r05 grids. Workaround are applied for F2010 ne4, ne4pg2, ne11 grids, 1850 NARRM, and SSP370 and SSP585 ne30pg2 grid, with placeholder for TOP-related variables. The TOP developers will update these files. Land initial files for several wcprod F2010 and F20R tests with older trigrid are disabled. The trigrid for the tests will be updated at a later time along with new initial files. [non-BFB] for all F and B-cases. [NML] extra default namelist variables in atm_in and lnd_in along with some update on input files
Merged to next. |
Restore the fix in PR 5252 The fix was reverted via #5970 for creating v3alpha03 tag. [NBFB] relative to the state before this revert of revert.
Merged to master. |
Restore the fix in PR 5252 The fix was reverted via #5970 for creating v3alpha03 tag. [NBFB] relative to the state before this revert of revert.
Notes on a chrysalis' diffs
ne30_oECv3.F2010 tests on gpc12 failing, need new surfdata for ne30np4 |
To set default the extra parameters for atm and lnd used by v3alpha03 configuration.
The merge of this PR should create a state ready for tagging v3alpha03.
Land surface data for WCYCL config are updated to enable subgrid topographic
radiative parameterization (TOP). The surfdata files for simyr 1850 and 2010 are fully
ready for ne30pg2 and r05 grids. Workaround are applied for F2010 ne4, ne4pg2, ne11
grids, 1850 NARRM, and SSP370 and SSP585 ne30pg2 grid, with placeholder for
TOP-related variables. The TOP developers will update these files.
Land initial files for several wcprod F2010 and F20R tests with older trigrid are disabled.
The trigrid for the tests will be updated at a later time along with new initial files.
[non-BFB] for all F and B-cases.
[NML] extra default namelist variables in atm_in and lnd_in along with some update on input files
The change on elm to enable use_top_solar_rad for water cycle production config to be added.
#5252 is temporarily reverted in order for the target v3alpha03 tag to reproduce coupled v3alpha03 simulation. It will be restored after this and a similar PR for wrapping up v3alpha04 config are merged. With proper reproducibility tests done, all these PRs (including revert the revert of #5252) should happen on the same day, to avoid repeated diffs for the same cime tests.