Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the hyperlink for local pages #5961

Closed
wants to merge 1 commit into from
Closed

Fixes the hyperlink for local pages #5961

wants to merge 1 commit into from

Conversation

bishtgautam
Copy link
Contributor

The fix for hyperlink is based on the following webpage
https://stackoverflow.com/questions/48063231/mkdocs-hyperlink-not-working-in-static-pages.

Fixes #5960

@bishtgautam bishtgautam requested a review from rljacob September 27, 2023 03:11
@rljacob rljacob requested review from mahf708 and removed request for rljacob September 27, 2023 03:52
mahf708
mahf708 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@mahf708 mahf708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

(As a side rant: I disagree with Rob in that I'd encourage people not to build the docs locally precisely because of these types of annoying things ... I put together #5951 for this very reason)

@bishtgautam
Copy link
Contributor Author

This PR is not needed. Instead, use mkdocs serve (see notes here).

@bishtgautam bishtgautam closed this Oct 9, 2023
@bishtgautam bishtgautam deleted the bishtgautam/docs/fix-hyperlinks-locally branch October 9, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahf708 mahf708 mahf708 approved these changes

Assignees

@rljacob rljacob

Labels
bug fix PR Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hyperlinks in documentation don't work correctly locally
3 participants
@bishtgautam @mahf708 @rljacob