Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new SOwISC12to60E3r1 ocean and sea-ice mesh #5935

Closed
wants to merge 8 commits into from
Closed

Add new SOwISC12to60E3r1 ocean and sea-ice mesh #5935

wants to merge 8 commits into from

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Sep 19, 2023 •
edited
Loading

Long name: SOwISC12to60kmL64E3SMv3r1

This version of the Southern Ocean Regionally Refined Mesh (SORRM) has the same distribution of resolution as in the E3SM v2 version of the mesh MPAS-Dev/compass#37, including:

  • 12 km resolution around Antarctica
  • 45 km resolution at southern mid-latitudes
  • 30 km resolution at the equator and the north Atlantic
  • 60 km resolution in the north Pacific
  • 35 km resolution in the Arctic

It matches the EC30to60 (#5927) mesh except in the Southern Ocean and north Atlantic.

This is a proposed E3SM v3 (E3) mesh for polar (formerly cryosphere) simulations. It is also being considered for flagship coupled simulations because of its strong AMOC. This is revision 1 (r1) of the mesh, since we caught and fixed the issues with Greenland topography (seen in earlier revisions of EC and Icos meshes) before any substantial testing was performed.

The mesh was created using compass, specifically this tag: https://github.com/MPAS-Dev/compass/releases/tag/mesh_SOwISC12to60E3r1

A G-case with data iceberg melt fluxes (DIB) and data ice-shelf melt fluxes (DISMF) has been run for 30 years, with MPAS-Analysis output available here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.jwolfe/20230905.G-test.SOwISC12to60E3r1.anvil/html/

The mesh and the G-case results are being reviewed here:
https://acme-climate.atlassian.net/wiki/spaces/OO/pages/3894181889/Review+SOwISC12to60E3r1

A B-case will begin shortly and analysis will be posted here and on the review page as soon as it is available.

@xylar xylar added mpas-ocean mpas-seaice BFB PR leaves answers BFB labels Sep 19, 2023
@xylar
Copy link
Contributor Author

xylar commented Sep 19, 2023

This branch is based off of #5927 and will be rebased after that gets merged.

Relevant discussion can be found at E3SM-Ocean-Discussion#61

@xylar xylar mentioned this pull request Sep 19, 2023
Closed
mark-petersen
mark-petersen approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@mark-petersen mark-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed mesh, coastlines, critical passages, and MPAS-Analysis simulation results.

proteanplanet
proteanplanet approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@proteanplanet proteanplanet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coastlines, shallow bathymetry, through-flow regions, and cavity geometry have been checked.

@xylar xylar mentioned this pull request Sep 20, 2023
Closed
@rljacob rljacob added this to the v3.0alpha05 milestone Oct 12, 2023
@xylar xylar force-pushed the mesh/add-sowisc12to60e3r1 branch from 1295b84 to e070301 Compare October 26, 2023 19:10
rljacob
rljacob requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@rljacob rljacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bilin maps need to be redone with TempestRemap. Map names need to be changed to match naming convention.

@xylar xylar force-pushed the mesh/add-sowisc12to60e3r1 branch from e070301 to bec1483 Compare November 15, 2023 17:29
@jonbob
Copy link
Contributor

jonbob commented Nov 15, 2023

I made updated domain and mapping files, changed config_grids.xml to match, and staged them for testing on the local inputdata space on lcdc. I also ran smoke tests successfully for:

  • T62_SOwISC12to60E3r1.CMPASO-IAF
  • TL319_SOwISC12to60E3r1.GMPAS-JRA1p5
  • ne30pg2_r05_SOwISC12to60E3r1.WCYCL1850
  • ne30pg2_r05_SOwISC12to60E3r1.WCYCL1850 with new nonlinear mapping file map_ne30pg2_to_SOwISC12to60E3r1_trfvnp2.20231115.nc

@jonbob
Copy link
Contributor

jonbob commented Nov 15, 2023

@rljacob -- can you please check the new domain and mapping files?

@darincomeau
Copy link
Member

I just added a commit to have this mesh use the previous SORRM PE layouts at LCRC.

@darincomeau
Copy link
Member

I'm getting FAIL SMS.TL319_SOwISC12to60E3r1.GMPAS-JRA1p5.anvil_intel RUN time=440. Looking into it...

@jonbob
Copy link
Contributor

jonbob commented Nov 16, 2023

@darincomeau -- maybe it's related to PR #6069, which has fixes to the mpas_io code? But I'm also suspicious that it's a memory issue because it's only running on four anvil nodes?

@darincomeau
Copy link
Member

Thanks @jonbob . I first ran into the error trying to run a G-case on 20 anvil nodes, so I then went back to do the SMS test. I'm trying a SMS_D.TL319_ECwISC30to60E3r2.GMPAS-JRA1p5.anvil_intel test now.

@darincomeau
Copy link
Member

SMS_D.TL319_SOwISC12to60E3r1.GMPAS-JRA1p5.chrysalis_intel runs.

I think there's an issue with G-cases in general on Anvil. I've been testing this branch and master, with SOwISC12to60E3r1 and ECwISC30to60E3r2, and every combination dies in init on Anvil (both with SMS test and running a G-case on 20 nodes, so memory shouldn't be the issue). The same combinations on Chrysalis run.

rljacob
rljacob reviewed Nov 17, 2023
View reviewed changes
cime_config/config_grids.xml
<gridmap atm_grid="TL319" ocn_grid="SOwISC12to60E3r1">
<map name="ATM2OCN_FMAPNAME">cpl/gridmaps/TL319/map_TL319_to_SOwISC12to60E3r1_traave.20231115.nc</map>
<map name="ATM2OCN_SMAPNAME">cpl/gridmaps/TL319/map_TL319_to_SOwISC12to60E3r1-nomask_trbilin.20231115.nc</map>
<map name="ATM2OCN_VMAPNAME">cpl/gridmaps/TL319/map_TL319_to_SOwISC12to60E3r1_patch.20231115.nc</map>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "esmfpatch"

rljacob
rljacob reviewed Nov 17, 2023
View reviewed changes
cime_config/config_grids.xml
<gridmap ocn_grid="SOwISC12to60E3r1" rof_grid="rx1">
<map name="ROF2OCN_ICE_RMAPNAME">cpl/cpl6/map_rx1_to_SOwISC12to60E3r1_smoothed.r150e300.230905.nc</map>
<map name="ROF2OCN_LIQ_RMAPNAME">cpl/cpl6/map_rx1_to_SOwISC12to60E3r1_smoothed.r150e300.230905.nc</map>
</gridmap>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be "cstmnn" instead of "smoothed"

rljacob
rljacob reviewed Nov 17, 2023
View reviewed changes
cime_config/config_grids.xml
<gridmap ocn_grid="SOwISC12to60E3r1" rof_grid="JRA025">
<map name="ROF2OCN_ICE_RMAPNAME">cpl/cpl6/map_JRA025_to_SOwISC12to60E3r1_smoothed.r150e300.230905.nc</map>
<map name="ROF2OCN_LIQ_RMAPNAME">cpl/cpl6/map_JRA025_to_SOwISC12to60E3r1_smoothed.r150e300.230905.nc</map>
</gridmap>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be "cstmnn" instead of "smoothed".

rljacob
rljacob reviewed Nov 17, 2023
View reviewed changes
cime_config/config_grids.xml
<gridmap ocn_grid="SOwISC12to60E3r1" rof_grid="r05">
<map name="ROF2OCN_ICE_RMAPNAME">cpl/cpl6/map_r05_to_SOwISC12to60E3r1_smoothed.r150e300.230905.nc</map>
<map name="ROF2OCN_LIQ_RMAPNAME">cpl/cpl6/map_r05_to_SOwISC12to60E3r1_smoothed.r150e300.230905.nc</map>
</gridmap>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be "cstmnn" instead of "smoothed".

@xylar xylar marked this pull request as draft November 20, 2023 00:56
@xylar
Copy link
Contributor Author

xylar commented Nov 20, 2023

I'm putting this in draft mode because I just discovered a bug in landIceMask (which affects the initial condition as well as several mapping files) over the weekend.

MPAS-Dev/compass#732

@xylar
Copy link
Contributor Author

xylar commented Nov 20, 2023

Closing this because of the bug above. Will make a new version of the mesh without the bug.

@xylar xylar closed this Nov 20, 2023
@xylar xylar deleted the mesh/add-sowisc12to60e3r1 branch January 7, 2024 16:42
@xylar xylar restored the mesh/add-sowisc12to60e3r1 branch January 7, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rljacob rljacob rljacob requested changes

@proteanplanet proteanplanet proteanplanet approved these changes

@mark-petersen mark-petersen mark-petersen approved these changes

@darincomeau darincomeau darincomeau approved these changes

@stephenprice stephenprice Awaiting requested review from stephenprice

Assignees

@jonbob jonbob

Labels
BFB PR leaves answers BFB mpas-ocean mpas-seaice
Projects
None yet
Milestone
v3.0beta01
Development

Successfully merging this pull request may close these issues.
6 participants
@xylar @jonbob @darincomeau @rljacob @mark-petersen @proteanplanet