Ocean bugfix to allow users to disable tracer tendencies with RK4 time integrator #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
approved these changes
Mar 11, 2023
|
@sbrus89 It seems from your comment #5418 (comment) that you have already verified that this works with the dam break test. Did you want to do any more testing before approving? |
jonbob
added a commit
that referenced
this pull request
Mar 30, 2023
Ocean bugfix to allow users to disable tracer tendencies with RK4 In the case where `config_disable_tr_all_tend = .true.` and `config_time_integrator = 'RK4'`: 1. We enforce no time updates to active tracers 2. We also completely bypass the RK4 tracer tendency update (as opposed to just the update within `ocn_tend_tracer`), which saves a little time In principle, only (2) would be needed, but we find that there is contamination of the tracer fields without (1) that leads to model crashes. We find that after these changes, model runtimes are still ~30% faster when tracers are disabled. Fixes #5518 [BFB]
|
passes:
merged to next |
|
merged to master |
xylar
added a commit
to xylar/compass
that referenced
this pull request
Apr 2, 2023
This merge updates the E3SM-Project submodule from [c9201a4](https://github.com/E3SM-Project/E3SM/tree/c9201a4f44540bb74cb3650e32bcbe27fb762ab1) to [b4d5b10600](https://github.com/E3SM-Project/E3SM/tree/b4d5b10600). This update includes the following MPAS-Ocean and MPAS-Frameworks PRs (check mark indicates bit-for-bit with previous PR in the list): - [ ] (ocn) E3SM-Project/E3SM#5254 - [ ] (fwk) E3SM-Project/E3SM#5490 - [ ] (ocn) E3SM-Project/E3SM#5541 - [ ] (fwk) E3SM-Project/E3SM#5498 - [ ] (ocn) E3SM-Project/E3SM#5564 - [ ] (ocn) E3SM-Project/E3SM#5553 - [ ] (ocn) E3SM-Project/E3SM#5519
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where
config_disable_tr_all_tend = .true.andconfig_time_integrator = 'RK4':ocn_tend_tracer), which saves a little time (b4e9ec1).In principle, only (2) would be needed, but we find that there is contamination of the tracer fields without (1) that leads to model crashes.
We find that after these changes, model runtimes are still ~30% faster when tracers are disabled.
Fixes #5518
[BFB]