address comments

E3SM-Project · Oct 16, 2023 · f85ea21 · f85ea21
1 parent 8057ebc
commit f85ea21
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 4 deletions.
diff --git a/components/elm/src/biogeophys/SoilHydrologyMod.F90 b/components/elm/src/biogeophys/SoilHydrologyMod.F90
@@ -552,7 +552,7 @@ subroutine Infiltration(bounds, num_hydrologyc, filter_hydrologyc, num_urbanc, f
                 if ( use_modified_infil ) then
                    ! Assume frac_h2osfc occurs on top of fsat
                    if (frac_h2osfc(c) <= fsat(c)) then
-                     qflx_h2osfc_drain(c)=0
+                     qflx_h2osfc_drain(c)=0._r8
                    else
                      qflx_h2osfc_drain(c)=min((frac_h2osfc(c)-fsat(c))*qinmax,h2osfc(c)/dtime)
                    endif

diff --git a/components/elm/src/biogeophys/SoilHydrologyType.F90 b/components/elm/src/biogeophys/SoilHydrologyType.F90
@@ -66,7 +66,7 @@ Module SoilHydrologyType
      real(r8), pointer :: i_0_col           (:)     => null()! col VIC average saturation in top soil layers
      real(r8), pointer :: ice_col           (:,:)   => null()! col VIC soil ice (kg/m2) for VIC soil layers
      real(r8), pointer :: fover             (:)     => null()! decay factor for surface runoff
-     real(r8), pointer :: pc                (:)     => null()! surface water threshold
+     real(r8), pointer :: pc                (:)     => null()! surface water threshold probability
 
    contains
 

diff --git a/components/elm/src/external_models/emi/src/elm_stub/utils/clm_varcon.F90 b/components/elm/src/external_models/emi/src/elm_stub/utils/clm_varcon.F90
@@ -43,7 +43,6 @@ module clm_varcon
 
   real(r8), parameter :: n_melt=0.7     !fsca shape parameter
   real(r8), parameter :: e_ice=6.0      !soil ice impedance factor
-  !real(r8), parameter :: pc = 0.4       !threshold probability
   real(r8), parameter :: mu = 0.13889   !connectivity exponent
   real(r8) :: grav   = SHR_CONST_G      !gravity constant [m/s2]
   real(r8) :: sb     = SHR_CONST_STEBOL !stefan-boltzmann constant  [W/m2/K4]

diff --git a/components/elm/src/main/elm_varcon.F90 b/components/elm/src/main/elm_varcon.F90
@@ -42,7 +42,6 @@ module elm_varcon
 
   real(r8), parameter :: n_melt=0.7                         ! fsca shape parameter
   real(r8), parameter :: e_ice=6.0                          ! soil ice impedance factor
-  !real(r8), parameter :: pc = 0.4                           ! threshold probability
   real(r8), parameter :: mu = 0.13889                       ! connectivity exponent 
   real(r8) :: grav   = SHR_CONST_G                          ! gravity constant [m/s2]
   real(r8) :: sb     = SHR_CONST_STEBOL                     ! stefan-boltzmann constant  [W/m2/K4]