-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FRIS meshes #75
FRIS meshes #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@irenavankova, this looks amazing, just as I expected!
One small thing that you had no way to know about is that the name of the branch will need to change before this moves to E3SM, see: https://acme-climate.atlassian.net/wiki/spaces/DOC/pages/2523172/Branch+Tag+and+Version+name+conventions
I would suggest: ocn/add-fris-meshes
Another comment is that it would be great to make the PR to Copass for the code you used to create these meshes at the same time as (or before) the E3SM PR for adding the meshes.
One more thing before this goes to E3SM, we need to put all the mesh data from files_for_e3sm/assembled_files
from Compass for each of these meshes in /lcrc/group/e3sm/public_html/
and make sure everyone in the E3SM has write permission to those files and directories.
@jonbob, could you have a quick look at this before @irenavankova moves it over to E3SM? |
@xylar -- sure, let me take a peek. What is our goal here? |
This is to add the 4 meshes that Irena has been using for her research in part to give more visibility to her project and in part so the configurations could be run in the future by herself or others without having to do a nasty rebase onto the latest E3SM master. The meshes would be brought in as a BFB feature. I don't think they qualify as a stealth feature because they are not meant to be available for B cases, just for G or C cases. |
</domain> | ||
|
||
<domain name="FRISwISC04to60E3r1"> | ||
<nx>718054</nx> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@irenavankova - the domain size should probably be different for each of the meshes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I fixed that and pushed the change.
I hate to say it, but I'll need to regenerate the mapping files to match the v3 naming convention. It won't take long, but something we'll have to do |
Oh, shoot! Sorry to create extra work for you. |
The diagnostics and inputdata are now in /lcrc/group/e3sm/public_html for all 4 meshes with write permissions. |
Moved to E3SM |
Meshes with high resolution in the southern Weddell Sea and beneath the Filchner Ronne Ice Shelf (FRIS). The meshes go down to 1, 2, 4, and 8 km beneath FRIS and on the continental shelf in front of it.