Disable land ice frazil unless ISMF is on

[cbegeman]

This PR turns land ice frazil off by default and re-enables it when ice-shelf melt fluxes are enabled in standalone or coupled mode. Land ice frazil is not enabled in data ISMF because frazil fluxes are already included in satellite-derived ISMF products.

[cbegeman]

@jonbob and @darincomeau Can you both take a look at this PR (last 2 commits) when you have a chance and let me know if this seems appropriate to you?

[darincomeau]

Thanks @cbegeman , I think this approach looks like what we want. I can test it and make sure it's working as intended.

[cbegeman]

@darincomeau That would be great!

[xylar]

This looks right to me!

[darincomeau]

/lcrc/group/e3sm/ac.dcomeau/scratch/chrys/ERS_Ld5.T62_oQU240wLI.GMPAS-DIB-IAF-DISMF.chrysalis_intel.20240613_165348_cfi0j4/run/mpaso_in: config_frazil_under_land_ice = .false.
/lcrc/group/e3sm/ac.dcomeau/scratch/chrys/ERS_Ld5.T62_oQU240wLI.GMPAS-DIB-IAF-PISMF.chrysalis_intel.20240613_165348_cfi0j4/run/mpaso_in: config_frazil_under_land_ice = .true.
/lcrc/group/e3sm/ac.dcomeau/scratch/chrys/PEM_Ln5.T62_oQU240wLI.GMPAS-DIB-IAF-DISMF.chrysalis_intel.20240613_165348_cfi0j4/run/mpaso_in: config_frazil_under_land_ice = .false.
/lcrc/group/e3sm/ac.dcomeau/scratch/chrys/PEM_Ln5.T62_oQU240wLI.GMPAS-DIB-IAF-PISMF.chrysalis_intel.20240613_165348_cfi0j4/run/mpaso_in: config_frazil_under_land_ice = .true.
/lcrc/group/e3sm/ac.dcomeau/scratch/chrys/PET_Ln5.T62_oQU240wLI.GMPAS-DIB-IAF-DISMF.chrysalis_intel.20240613_165348_cfi0j4/run/mpaso_in: config_frazil_under_land_ice = .false.
/lcrc/group/e3sm/ac.dcomeau/scratch/chrys/PET_Ln5.T62_oQU240wLI.GMPAS-DIB-IAF-PISMF.chrysalis_intel.20240613_165348_cfi0j4/run/mpaso_in: config_frazil_under_land_ice = .true.
/lcrc/group/e3sm/ac.dcomeau/scratch/chrys/SMS_D_Ld1.TL319_IcoswISC30E3r5.GMPAS-JRA1p5-DIB-PISMF.chrysalis_intel.mpaso-jra_1958.20240613_165348_cfi0j4/run/mpaso_in: config_frazil_under_land_ice = .true.
/lcrc/group/e3sm/ac.dcomeau/scratch/chrys/SMS_P512.ne30pg2_r05_IcoswISC30E3r5.CRYO1850.chrysalis_intel.20240613_182655_6j470s/run/mpaso_in: config_frazil_under_land_ice = .true.
/lcrc/group/e3sm/ac.dcomeau/scratch/chrys/SMS_P512.ne30pg2_r05_IcoswISC30E3r5.CRYO1850-DISMF.chrysalis_intel.20240613_180733_yzihnm/run/mpaso_in: config_frazil_under_land_ice = .false.
/lcrc/group/e3sm/ac.dcomeau/scratch/chrys/SMS_P512.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.20240613_174817_kgaob4/run/mpaso_in: config_frazil_under_land_ice = .false.

Seems to be working as intended - thanks @cbegeman !

[darincomeau]

Approved based on above testing.

[cbegeman]

@darincomeau Thanks so much for testing!

[cbegeman]

@jonbob When you have a chance, can you take a look and let me know if this is ready to move over to E3SM? As a reminder, we want this merged so that we don't accidentally have frazil under land ice in our upcoming non-cryo v3 runs.

[jonbob]

@cbegeman -- the only thing I'm concerned about is that the logic is in a different namelist group, so it's not getting set in the same section. I don't think it's a big deal, but it might be clearer to duplicate the $OCN_ISMF logic in the frazil_ice namelist section?

[cbegeman]

@cbegeman -- the only thing I'm concerned about is that the logic is in a different namelist group, so it's not getting set in the same section. I don't think it's a big deal, but it might be clearer to duplicate the $OCN_ISMF logic in the frazil_ice namelist section?

Yes, I noticed that. I'm happy to duplicate the logic for clarity. I'll push that change shortly.

[cbegeman]

@jonbob Your requested changes have been made. Would you like me to do any further testing before migrating to e3sm?

[jonbob]

Looks perfect

[jonbob]

let's get this to e3sm and I'll merge it as quickly as possible

[xylar]

I didn't realize I was the hold up here. This is ready to go to E3SM as far as I'm concerned. Thanks for the work on it, @cbegeman!

[cbegeman]

Closed in favor of E3SM-Project#6501

Thanks for reviewing @jonbob @darincomeau @xylar!