Pull request #145: Fix issue with char being unsigned on ARM

Merge in OP/openkit-native from noissue/arm-signed-unsigned-issue-fix to release/2.0 * commit '4121e34f6e3103f80b66b29c8364f9961f61dcfc': public/CHANGELOG.md edited online with Bitbucket Fix issue with char being unsigned on ARM GitOrigin-RevId: 5be5ef54d291eef55b017450bad3efcec543be68
Dynatrace · Jul 6, 2021 · 6583ad9 · 6583ad9
1 parent df9852f
commit 6583ad9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,9 @@
 ### Added
 - Add libatomic as additional link library if required.
 
+### Changed
+- Fix issue in JSON parser for compilers/platforms with unsigned char.
+
 ## 2.0.0 [Release date: 2021-05-19]
 [GitHub Releases](https://github.com/Dynatrace/openkit-native/releases/tag/v2.0.0)
 

diff --git a/src/OpenKit.cmake b/src/OpenKit.cmake
@@ -375,12 +375,12 @@ macro(_generate_open_kit_version_rc)
 endmacro()
 
 macro(_check_for_additional_libs libs)
-    set(libs)
+    set(${libs})
 
     # check if libatomic is required
     include (CheckAtomic)
     if (HAVE_CXX_ATOMICS_WITH_LIB)
-        list (append libs "atomic")
+        list (APPEND ${libs} "atomic")
     endif ()
 
 endmacro()

diff --git a/src/util/json/reader/DefaultResettableReader.cxx b/src/util/json/reader/DefaultResettableReader.cxx
@@ -36,10 +36,7 @@ int32_t DefaultResettableReader::read()
 		return EOF;
 	}
 
-	char character = EOF;
-	mReader->get(character);
-
-	return character;
+	return mReader->get();
 }
 
 void DefaultResettableReader::mark(int32_t lookAheadLimit)