Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PodDisruptionBudget not obeying highAvailability flag #4013

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

luhi-DT
Copy link
Collaborator

@luhi-DT luhi-DT commented Nov 6, 2024

Description

Ticket: https://dt-rnd.atlassian.net/browse/DAQ-2140

Fixes #4008

Currently the highAvailability flag does not control the creation of the PodDisruptionBudget

How can this be tested?

set highAvailability to false in values file -> make manifest -> check if the PDB is there

@luhi-DT luhi-DT added the bug Something isn't working label Nov 6, 2024
@luhi-DT luhi-DT requested a review from a team as a code owner November 6, 2024 10:47
@luhi-DT luhi-DT changed the title Fix PodDisruptionBudget not adhering to highAvailability flag Fix PodDisruptionBudget not obeying highAvailability flag Nov 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.60%. Comparing base (b1fa5e4) to head (e5f18d6).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4013   +/-   ##
=======================================
  Coverage   64.60%   64.60%           
=======================================
  Files         397      397           
  Lines       26387    26387           
=======================================
  Hits        17047    17047           
  Misses       8017     8017           
  Partials     1323     1323           
Flag Coverage Δ
unittests 64.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@waodim waodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it - works 👍

@luhi-DT luhi-DT merged commit f4c6191 into main Nov 6, 2024
20 checks passed
@luhi-DT luhi-DT deleted the fix/pdb-in-high-availability branch November 6, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webhook PodDistributionBudget created when HighAvailability is set to False via Helm Deployment
4 participants