Fixing DevTools Console Errors #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing DevTools Console Errors
|
This is what is shown in the Chrome DevTools. |
|
👍 |
|
@RobertGlobant20 If you think this PR is ready, would you make this ready for review and bump up the package version? |
Bumping up librariejs version
|
QilongTang
approved these changes
May 13, 2024
Enzo707
pushed a commit
to Enzo707/librarie.js
that referenced
this pull request
May 16, 2024
This reverts commit f5853c1.
QilongTang
pushed a commit
that referenced
this pull request
May 17, 2024
* Revert "Fixing DevTools Console Errors (#227)" This reverts commit f5853c1. * Revert "feat: move js code implemented directly on library.html (dynamo side) to librariejs (#225)" This reverts commit 5bd2f15. * remove resources on npm run production to not include them in published package * feat: make file structure consistent than other web components --------- Co-authored-by: enzo707 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix will remove most of errors shown in the Browser-DevTools console for Chrome when the library is loaded (problem reported by @mjkkirschner ).
The one related to LIBPLACEHOLDER will be still present (a similar to this one is still present in all the React components that we have in Dynamo).
FYI: @QilongTang @reddyashish