feat: move js code implemented directly on library.html (dynamo side) to librariejs #225
Conversation
Enzo707
force-pushed
the
DYN-6866/migrate-js-code-from-dynamo-to-librariejs-component
branch
from
e26df47 to
d134c5d
Compare
|
@Enzo707 with this changes, could you add a GIF showing the expected behavior when running the guided tours in Dynamo? |
@RobertGlobant20 I've tested and the guide works just fine |
|
looks like sonar cloud has found a few issues. |
@mjkkirschner Yes, we didn't implement sonarcloud validations from the start so every time we change a file the scan throws a bunch of issues. The one I couldn't address is related to a function we expose to be used on Dynamo side so seems to be defined but not used. Can we just merge it anyway or how should we proceed? |
|
Hi @Enzo707 Thanks for proposing this PR, is there a pairing PR on Dynamo side to remove these code? |
Not yet, I wanted to bring this up first. If you agree I can created a PR on Dynamo repo removing this code. |
|
@Enzo707 Also notice you may want to bump up the version number for this change so we can re-publish |
Sure, I can do that. I have to rebase this branch also, as we already merged Roberto's PR related to library search. |
Thanks, I am not sure about the rebase though. If you have not touched the same function, it may be fine |
|
…mo side) to librariejs (DynamoDS#225)" This reverts commit 5bd2f15.
* Revert "Fixing DevTools Console Errors (#227)" This reverts commit f5853c1. * Revert "feat: move js code implemented directly on library.html (dynamo side) to librariejs (#225)" This reverts commit 5bd2f15. * remove resources on npm run production to not include them in published package * feat: make file structure consistent than other web components --------- Co-authored-by: enzo707 <[email protected]>
We have implemented javascript code, at some point in the past, related to library web component functionalities, directly into Dynamo. So now that we want to consume library as npm package, we need to move that functionalities keeping all library's responsibilities together one side in order to just install the package into Dynamo side.