[DYN-7568] Tune-up crashes Dynamo when running all nodes in script with a selected family #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to address DYN-7568. Please see the ticket for full description of the issue.
The cause of the Revit & Dynamo crash was
ResetEngine()inResetProfiling()trying to start a transaction outside Revit's API. I removedResetEngine()and worked around this by looping through the nodes in the workspace and marking them as modified manually. This should achieve the same result.There might be some edge cases if we work with dynamic components, but it’s been stable in my tests so far.
@QilongTang
@reddyashish
@dnenov