[DYN-7701] Dynamo freeze on Run All in some cases #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ivaylo-matov resolve the conflicts on this. |
|
seen the fail. looking into it |
reddyashish
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to address DYN-7701
In some cases, running "Run All" was causing Dynamo to freeze up with no error messages. After looking into it, it seems the issue was due to long-running updates blocking the UI thread. I've used
Task.RunanduiContext.Postto handle these updates in the background, which seems to keep things running smoothly.For consistency and to streamline the code, I also replaced
collection.Dispatchercalls withuiContext.Post, asDispatcherwas causing some problems in Civil 3D anyway. I've also separated the UI update code from the main methods to clean-up the logic.