TuneUp improvement - handling groups with nodes from different states #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not bumped the version as I see #68 is not merged yet. Please let me know if I should update it to 1.0.14... |
reddyashish
approved these changes
Oct 11, 2024
|
Merging this first before bumping the version. So we should be good with 1.0.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR aims to address pint 5 (3.4 column) from this Mural board and this slack thread
TuneUp now adds a group header and displays the group's execution time in each DataGrid containing its nodes.
@QilongTang
@reddyashish
@dnenov
@Amoursol