[DYN-7436] Dynamo crashes upon exporting results if the destination file is open #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reddyashish
approved these changes
Oct 3, 2024
|
@ivaylo-matov Changes look good, we can do the same for Graph node manager. |
reddyashish
reviewed
Oct 3, 2024
| { | ||
| writer.WriteLine("Execution Order,Name,Execution Time (ms)"); | ||
| MessageBox.Show("The file is currently in use by another application. Please close the file before trying to overwrite it.", |
There was a problem hiding this comment.
@ivaylo-matov can you move these messages to resources so that they will be localized. You can do it in a different PR.
There was a problem hiding this comment.
Now addressed in this PR : #70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to address https://jira.autodesk.com/browse/DYN-7436
The code now check if the file is in use before trying to override it. Please let me know if this is acceptable and can implement it on
Node Graph Manager.@QilongTang
@reddyashish
@Amoursol
@dnenov