Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DYN-7334] Improvements following the feedback #57

Merged
merged 4 commits into from
Sep 20, 2024
Merged

[DYN-7334] Improvements following the feedback #57

merged 4 commits into from
Sep 20, 2024

Conversation

ivaylo-matov
Copy link
Contributor

@ivaylo-matov ivaylo-matov commented Sep 19, 2024 •
edited
Loading

This PR aims to address some of the resent feedback on TuneUp's revised control layout. It covers all points from column "3.3" of Mural with the exception of point 3.

  1. Hepl icon removed
  2. Centers on node when selected in the TuneUp's UI
  4. Show TuneUp is present in the Extensions menu even when language is not English
  5. UI changes to match the intended design
  6. Group title foreground color auto-adjusts for contrast with the background similarly to the groups in the workspace
  7. Jagged edges removed from group nodes

image

image

image

CenterOnNodeWhenSelected

@QilongTang
@reddyashish

@Amoursol
@dnenov

@ivaylo-matov
progress record
9fde6ac 
1. help icon removed
5. minor UI changes
7. jagged edges fixed
@ivaylo-matov
progress record
db37e8b 
2. zoom on node when selected in the UI
@ivaylo-matov
progress record
3438235 
6. group title font color auto-adjusts for contrast with background color
@ivaylo-matov
progress record
b20bf52 
4. TuneUp loads in Extensions in non-default languages
QilongTang
QilongTang reviewed Sep 19, 2024
View reviewed changes
TuneUp/TuneUpViewExtension.cs
// and does not appear in Dynamo 3.1+.
// We need to specify _View for TuneUpMenuItem to be added to the Extensions menu
var extensionsMenuItem = dynamoMenuItems.Where(item => item.Header.ToString() == "_View");
var extensionsMenuItem = dynamoMenuItems.Where(item => item.Header.ToString() == Resources.DynamoViewExtensionsMenu);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@QilongTang
Copy link
Contributor

What is the 3rd improvement? Just curious

@ivaylo-matov
Copy link
Contributor Author

What is the 3rd improvement? Just curious

The grouped nodes are not ordered correctly.
The initial execution of the graph works fine, but when you close and reopen it, the group and total-group-time nodes are displayed at the bottom of the grid. The order is correct if you re-execute the graph or sort the headers. The code is sorting the collection correctly, but there seems to be an issue with the UI not updating properly.

image

@reddyashish
Copy link
Contributor

What is the 3rd improvement? Just curious

The grouped nodes are not ordered correctly. The initial execution of the graph works fine, but when you close and reopen it, the group and total-group-time nodes are displayed at the bottom of the grid. The order is correct if you re-execute the graph or sort the headers. The code is sorting the collection correctly, but there seems to be an issue with the UI not updating properly.

image

So I will add this to one of the open tuneup tasks and we can do that for 3.4. Changes look good. Merging this.

@reddyashish reddyashish merged commit b48d057 into DynamoDS:master Sep 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reddyashish reddyashish reddyashish approved these changes

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivaylo-matov @QilongTang @reddyashish