-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DYN-7334] Revised TuneUp controls layout #53
Changes from all commits
a125274
ab90d78
d137ca1
c45041e
d189125
1eed1c0
e76198c
bccaa32
017bf09
01e3a47
c5b45ab
40aca3e
8a6f471
03b8c5d
2fe63db
9e5634c
4e41cab
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,6 @@ public class TuneUpViewExtension : ViewExtensionBase, IViewExtension | |
|
||
public override void Dispose() | ||
{ | ||
TuneUpView.Dispose(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason to removing the dispose on the view when the extension is closed? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. AFAICT it was only unsubscribing from DynamoWindow_SizeChanged, which is not needed anymore. |
||
} | ||
|
||
public override void Startup(ViewStartupParams p) | ||
|
@@ -34,7 +33,9 @@ public override void Loaded(ViewLoadedParams p) | |
TuneUpView = new TuneUpWindow(p, UniqueId) | ||
{ | ||
// Set the data context for the main grid in the window. | ||
NodeAnalysisTable = { DataContext = ViewModel }, | ||
LatestRunTable = { DataContext = ViewModel }, | ||
PreviousRunTable = { DataContext = ViewModel }, | ||
NotExecutedTable = { DataContext = ViewModel }, | ||
MainGrid = { DataContext = ViewModel }, | ||
Owner = p.DynamoWindow | ||
}; | ||
|
@@ -114,7 +115,7 @@ public override void Closed() | |
this.TuneUpMenuItem.IsChecked = false; | ||
|
||
// Reset DataGrid sorting order & direction | ||
ViewModel.SortingOrder = "number"; | ||
ViewModel.SortingOrder = TuneUpWindowViewModel.SortByNumber; | ||
ViewModel.SortDirection = System.ComponentModel.ListSortDirection.Ascending; | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add summary to this public property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done