Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT[DYN-2332] As a user I want Tuneup times color coded to visually highlight hot spots #50

Closed
wants to merge 3 commits into from

Conversation

ivaylo-matov
Copy link
Contributor

@ivaylo-matov ivaylo-matov commented Jul 15, 2024

Proof of concept for https://jira.autodesk.com/browse/DYN-2332

DYN-2332-Draft

Currently, the ToggleButton and controls for this feature are integrated into TuneUp's DataGrid. The colors update dynamically.

I wanted to get feedback on the following:

  • Is this workflow generally acceptable?
  • Has there been any UI/UX design work done for this feature?
  • It was mentioned that the goal for TuneUp is to become an out-of-the-box (OOTB) extension for Dynamo. If so, should these controls be moved to Dynamo's Preferences menu? If not, is the current location appropriate?

Thanks!

FYI
@QilongTang
@reddyashish
@Amoursol

@ivaylo-matov
Copy link
Contributor Author

There are conflicts here, but as this is just for preview, I will wait until the other RPs are merged before I resolve. Hope that's okay 🤞

@reddyashish
Copy link
Contributor

@ivaylo-matov This is the last PR left on tuneup. Once you resolve conflicts, I can merge

@ivaylo-matov
Copy link
Contributor Author

@reddyashish, this is not intended for merging but is just a proof of concept. Please see the description and my post on https://jira.autodesk.com/browse/DYN-2332 .
Could you please review this and let me know if the solution is acceptable? The ticket mentioned a UX design team meeting, but I'm unsure if it has occurred or what the outcome was.
If what I've done so far is enough, I'll clean up the code and create a proper PR.
Thanks 🙂

@mjkkirschner
Copy link
Member

could be auto calculate the min and max vals?

@QilongTang
Copy link
Contributor

@ivaylo-matov Could your resolve the merge conflicts so this one is ready for another look?

@ivaylo-matov
Copy link
Contributor Author

@QilongTang , all should be fine now. Thanks

@QilongTang
Copy link
Contributor

@reddyashish Would you take another look when you have time?

@QilongTang QilongTang requested a review from reddyashish August 5, 2024 15:53
@reddyashish
Copy link
Contributor

Changes look good, @ivaylo-matov do we need this on top of this redesign changes here #53?

@ivaylo-matov
Copy link
Contributor Author

Changes look good, @ivaylo-matov do we need this on top of this redesign changes here #53?

Hi @reddyashish , there's a new Figma design so I don't think this PR is relevant any more. I'll close it if that's okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants