-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT[DYN-2332] As a user I want Tuneup times color coded to visually highlight hot spots #50
Conversation
There are conflicts here, but as this is just for preview, I will wait until the other RPs are merged before I resolve. Hope that's okay 🤞 |
@ivaylo-matov This is the last PR left on tuneup. Once you resolve conflicts, I can merge |
@reddyashish, this is not intended for merging but is just a proof of concept. Please see the description and my post on https://jira.autodesk.com/browse/DYN-2332 . |
could be auto calculate the min and max vals? |
@ivaylo-matov Could your resolve the merge conflicts so this one is ready for another look? |
@QilongTang , all should be fine now. Thanks |
@reddyashish Would you take another look when you have time? |
Changes look good, @ivaylo-matov do we need this on top of this redesign changes here #53? |
Hi @reddyashish , there's a new Figma design so I don't think this PR is relevant any more. I'll close it if that's okay? |
Proof of concept for https://jira.autodesk.com/browse/DYN-2332
Currently, the
ToggleButton
and controls for this feature are integrated into TuneUp'sDataGrid
. The colors update dynamically.I wanted to get feedback on the following:
Thanks!
FYI
@QilongTang
@reddyashish
@Amoursol