DYN-7571 Add Compatibility Map route as an API #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Oct 11, 2024
|
|
||
| namespace Greg.Requests | ||
| { | ||
| public class GetCompatibilityMap : Request |
There was a problem hiding this comment.
Would you add some comments?
QilongTang
reviewed
Oct 11, 2024
|
|
||
| internal override void Build(ref RestRequest request) | ||
| { | ||
| } |
There was a problem hiding this comment.
Is this override still required if not implemented?
There was a problem hiding this comment.
Yes, required as we are extending the abstract class Request
QilongTang
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
GetCompatibilityMapshould call the /host_map route on package manager and return host mapping in Greg.Declarations
Check these if you believe they are true
Reviewers
@DynamoDS/dynamo
FYIs
@dnenov