Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-7393 Update RestSharp to v112.0.0 #15494

Merged
merged 6 commits into from
Sep 23, 2024
Merged

DYN-7393 Update RestSharp to v112.0.0 #15494

merged 6 commits into from
Sep 23, 2024

Conversation

QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Sep 19, 2024

Purpose

Update RestSharp to align with Revit GL and Greg -> DynamoDS/PackageManagerClient#110.

Also add some code to guard the edge case that fetching hosts failure would crash Dynamo so user can report the error from the log
image

The PR has been updated with Greg version change as well so that Package Manager client in Dynamo is back to work. FYI: @zeusongit

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Update RestSharp to align with Revit GL and Greg

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

github-actions bot commented Sep 19, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang changed the title Update RestSharp DYN-7393 Update RestSharp Sep 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7393

@QilongTang QilongTang added this to the 3.4 milestone Sep 23, 2024
@QilongTang QilongTang changed the title DYN-7393 Update RestSharp DYN-7393 Update RestSharp to v112.0.0 Sep 23, 2024
@QilongTang QilongTang marked this pull request as ready for review September 23, 2024 01:59
@QilongTang
Copy link
Contributor Author

@QilongTang
Copy link
Contributor Author

The second run passed

@QilongTang QilongTang merged commit 702c7f8 into master Sep 23, 2024
23 of 24 checks passed
@QilongTang QilongTang deleted the UpdateRestSharp branch September 23, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants