Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes wording error #378

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Fixes wording error #378

merged 2 commits into from
Nov 28, 2023

Conversation

Ranj101
Copy link
Contributor

@Ranj101 Ranj101 commented Nov 15, 2023

No description provided.

josephdecock
josephdecock approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@josephdecock
Copy link
Member

We will want this in the v6 and v7 version of the docs.

josephdecock
josephdecock requested changes Nov 15, 2023
View reviewed changes
Copy link
Member

@josephdecock josephdecock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'll hold off on merging to remind myself to handle the different doc versions.

@josephdecock josephdecock merged commit c31aaf6 into DuendeSoftware:main Nov 28, 2023
2 checks passed
@josephdecock josephdecock mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephdecock josephdecock josephdecock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ranj101 @josephdecock