Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add children links to config & DCR #369

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Add children links to config & DCR #369

merged 3 commits into from
Nov 14, 2023

Conversation

AndersAbel
Copy link
Member

No description provided.

Copy link

github-actions bot commented Nov 9, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-369.eastus2.azurestaticapps.net

@brockallen
Copy link
Member

Were those deliberately not added when originally created? // @josephdecock

@AndersAbel
Copy link
Member Author

I referred someone to https://docs.duendesoftware.com/identityserver/v6/configuration/dcr/ and that page felt a bit like a dead end. You'd have to check the TOC on the left side to see that there's a lot of content in sub sections.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-369.eastus2.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://happy-ocean-048b8e60f-369.eastus2.azurestaticapps.net

@josephdecock
Copy link
Member

josephdecock commented Nov 14, 2023

The top level configuration page has only 1 child page, so its toc looks a little awkward. I just pushed a change to instead put the link to the dcr child page as an inline link. That does have the downside of de-emphasizing the link to the dcr content, but I think that's the tradeoff I prefer. That page also just isn't nearly as much of a dead end, since it has half a dozen links already. Thoughts?

On the dcr page, there are many subpages and I completely agree that the toc makes the page better.

@AndersAbel AndersAbel merged commit cbc3025 into main Nov 14, 2023
2 checks passed
@AndersAbel AndersAbel deleted the anders/DCR-toc branch November 14, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants