fix(next-pwa): fixed __PWA_SW_ENTRY_WORKER__ being undefined (#34)

[bump]
DuCanhGH · Jun 16, 2023 · 9850306 · 9850306
1 parent 9c8b3a1
commit 9850306
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 11 deletions.
diff --git a/.changeset/short-ducks-glow.md b/.changeset/short-ducks-glow.md
@@ -0,0 +1,7 @@
+---
+"@ducanh2912/next-pwa": patch
+---
+
+fix(next-pwa): fixed `__PWA_SW_ENTRY_WORKER__` being undefined
+
+- This happens when `cacheOnFrontEndNav` is not enabled, which causes `webpack.DefinePlugin` to not be called.
diff --git a/packages/next-pwa/src/build-sw-entry-worker.ts b/packages/next-pwa/src/build-sw-entry-worker.ts
@@ -16,11 +16,16 @@ export const buildSWEntryWorker = ({
   id,
   destDir,
   minify,
+  shouldGenSWEWorker,
 }: {
   id: string;
   destDir: string;
   minify: boolean;
+  shouldGenSWEWorker: boolean;
 }) => {
+  if (!shouldGenSWEWorker) {
+    return undefined;
+  }
   const name = `sw-entry-worker-${id}.js`;
   const swEntryWorkerEntry = path.join(__dirname, `sw-entry-worker.js`);
 

diff --git a/packages/next-pwa/src/index.ts b/packages/next-pwa/src/index.ts
@@ -159,18 +159,18 @@ const withPWAInit = (pluginOptions: PluginOptions = {}): WithPWA => {
 
         if (!options.isServer) {
           const _dest = path.join(options.dir, dest);
+          const sweWorkerName = buildSWEntryWorker({
+            id: buildId,
+            destDir: _dest,
+            minify: !dev,
+            shouldGenSWEWorker: cacheOnFrontEndNav,
+          });
 
-          if (cacheOnFrontEndNav) {
-            config.plugins.push(
-              new webpack.DefinePlugin({
-                __PWA_SW_ENTRY_WORKER__: `'${buildSWEntryWorker({
-                  id: buildId,
-                  destDir: _dest,
-                  minify: !dev,
-                })}'`,
-              })
-            );
-          }
+          config.plugins.push(
+            new webpack.DefinePlugin({
+              __PWA_SW_ENTRY_WORKER__: sweWorkerName && `'${sweWorkerName}'`,
+            })
+          );
 
           const customWorkerScriptName = buildCustomWorker({
             id: buildId,