Fix compatibility gdal3 proj6 #384
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dschlaep
commented
Oct 6, 2020
dschlaep
commented
- Minimal updates to accommodate GDAL3+/PROJ6+
- Introduces new dependency on package rSW2st
- move function `crs_units` to new package `rSW2space` to handle different crs - make sure that we have a sufficiently new `rgdal` for the "new generation" crs argument checks
only white-space changes
(Unpublished) package `rSW2space` renamed to `rSW2st` (spatio-temporal)
make it easier to install our set of package dependencies
only white-space adjustments; no changes to the code
- use `sf` for handling pre- and post- GDAL3+/PROJ6+ correctly (see https://www.r-spatial.org/r/2020/03/17/wkt.html) - use `sf::st_crs()` for all coordinate reference system functionality: * changed (almost all instanced of) `sp::CRS()` and `raster::crs()` to `as(sf::st_crs(), "CRS")` * changed `raster::compareCRS()` to `sf::st_crs() == sf::st_crs()` * replace all crs encoded as proj4 character strings with epsg codes - crs of daymet which is a Lambert Conformal Conic projection is still a proj4 representation; --> todo: convert to WKT2 --> todo: replace all `sp` with `sf` functionality - where possible
- moved `methods` to "Depends" - moved `rSOILWAT2`, `rSW2utils`, `rSW2st`, and `rSW2fun` to "Imports"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.