This repository has been archived by the owner on Feb 19, 2021. It is now read-only.
Fix compile time and runtime issues with testapp #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes the issue #173 and #172 |
lbegani
changed the title
shakthi-prashanth-m
suggested changes
Jun 7, 2018
| sleep(intervel + 1); | ||
| log_info("Enter the interval in which images to be taken"); | ||
| int interval; | ||
| scanf("%d", &interval); |
There was a problem hiding this comment.
Using scanf is vulnerable and discouraged in C++. If user provides non-digit input, then app behavior is undefined. So, I suggest to use std::cin. I suggest to apply throughout the test application.
test/test_mavlink_protocol.cpp
Outdated
| @@ -40,6 +40,8 @@ | |||
|
|
|||
| using namespace std; | |||
|
|
|||
| void discovercam(void *cntx); | |||
There was a problem hiding this comment.
What about making it a public static method of Drone ?
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * This file is part of the Camera Streaming Daemon project | |||
| * This file is part of the Dronecode Camera Manager | |||
There was a problem hiding this comment.
I suggest to add a brief description of what the app does. Sample here.
|
@lbegani should this still go in? |
test/test_mavlink_protocol.cpp
Outdated
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| /** | |||
|
|
|||
| @brief This is a test application to test mavlink messages in the Camera Streaming Daemon. | |||
| @brief This is a test application to test mavlink imessages in the Dronecode Camera Manager. | |||
For now, we can close this by merging it. Improvements can go in later. |
|
To me it looks like @shakthi-prashanth-m 's comments should be addressed though. I might add them before merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.