[Exchanges] support spot stop losses #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herklos
reviewed
Dec 8, 2024
| trading_enums.ExchangeTypes.SPOT.value: { | ||
| # order that should be self-managed by OctoBot | ||
| trading_enums.ExchangeSupportedElements.UNSUPPORTED_ORDERS.value: [ | ||
| # trading_enums.TraderOrderType.STOP_LOSS, # supported on spot (as spot limit) |
There was a problem hiding this comment.
should we also allow stop loss limit as it is supported?
GuillaumeDSM
commented
Dec 8, 2024
| stop_price = price | ||
| price = float(decimal.Decimal(str(price)) * self.STOP_LIMIT_ORDER_INSTANT_FILL_PRICE_RATIO) | ||
| # use limit stop loss with a "normally instantly" filled price | ||
| return await self._create_limit_stop_loss_order(symbol, quantity, price, stop_price, side, params=params) |
There was a problem hiding this comment.
up to use _create_limit_stop_loss_order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.