Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coinbase] support portfolio id #1386

Merged
merged 2 commits into from
Nov 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 35 additions & 2 deletions Trading/Exchange/coinbase/coinbase_exchange.py
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,34 @@ async def get_account_id(self, **kwargs: dict) -> str:
try:
# warning might become deprecated
# https://docs.cloud.coinbase.com/sign-in-with-coinbase/docs/api-users
user_data = await self.connector.client.v2PrivateGetUser()
return user_data["data"]["id"]
portfolio_id = None
accounts = await self.connector.client.fetch_accounts()
# use portfolio id when possible to enable "coinbase subaccounts" which are called "portfolios"
# note: oldest portfolio portfolio id == user id (from previous v2PrivateGetUser) when using master account
portfolio_ids = set(account[ccxt_constants.CCXT_INFO]['retail_portfolio_id'] for account in accounts)
if len(portfolio_ids) != 1:
is_up_to_date_key = self._is_up_to_date_api_key()
if is_up_to_date_key:
self.logger.error(
f"Unexpected: failed to identify Coinbase portfolio id on up to date API keys: "
f"{portfolio_ids=}"
)
sorted_portfolios = sorted(
[
account[ccxt_constants.CCXT_INFO]
for account in accounts
],
key=lambda account: account["created_at"],
)
portfolio_id = sorted_portfolios[0]['retail_portfolio_id']
self.logger.info(
f"{len(portfolio_ids)} portfolio found on Coinbase account. "
f"This can happen with non up-to-date API keys ({is_up_to_date_key=}). "
f"Using the oldest portfolio id to bind to main account: {portfolio_id=}."
)
else:
portfolio_id = next(iter(portfolio_ids))
return portfolio_id
except ccxt.BaseError as err:
self.logger.exception(
err, True,
Expand All @@ -149,6 +175,13 @@ async def get_account_id(self, **kwargs: dict) -> str:
)
return trading_constants.DEFAULT_ACCOUNT_ID

def _is_up_to_date_api_key(self) -> bool:
return (
self.connector.client.apiKey.find('organizations/') >= 0 or
self.connector.client.apiKey.startswith('-----BEGIN')
)


@_coinbase_retrier
async def get_symbol_prices(self, symbol: str, time_frame: commons_enums.TimeFrames, limit: int = None,
**kwargs: dict) -> typing.Optional[list]:
Expand Down