Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutli tp #1372

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Mutli tp #1372

merged 2 commits into from
Oct 21, 2024

Conversation

GuillaumeDSM
Copy link
Member

@GuillaumeDSM GuillaumeDSM requested a review from Herklos October 21, 2024 17:44
@GuillaumeDSM GuillaumeDSM self-assigned this Oct 21, 2024
Herklos
Herklos approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@Herklos Herklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Trading/Mode/daily_trading_mode/tests/test_daily_trading_mode_consumer.py
assert not take_profit_order.is_open()
assert not take_profit_order.is_created()

# stop loss and 1 take profit and 5 additional (6 TP in total)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeDSM GuillaumeDSM enabled auto-merge (rebase) October 21, 2024 19:27
@GuillaumeDSM GuillaumeDSM merged commit 1a40c84 into dev Oct 21, 2024
7 checks passed
@GuillaumeDSM GuillaumeDSM deleted the mutli_tp branch October 21, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Herklos Herklos Herklos approved these changes

Assignees

@GuillaumeDSM GuillaumeDSM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeDSM @Herklos