[GPT] enable historical signals fetch #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeDSM
changed the title
Herklos
reviewed
Oct 27, 2023
| def get_version(self): | ||
| # later on, identify by its specs | ||
| # return f"{self.gpt_model}-{self.source}-{self.indicator}-{self.period}-{self.GLOBAL_VERSION}" | ||
| return "0.0.0" |
There was a problem hiding this comment.
I don't understand why the version should contains all these data and not just a number (here GLOBAL_VERISON)
Evaluator/TA/ai_evaluator/ai.py
Outdated
Comment on lines
114
to
118
| self.max_confidence_threshold = self.UI.user_input( | ||
| "max_confidence_threshold", enums.UserInputTypes.INT, | ||
| self.max_confidence_threshold, inputs, min_val=0, max_val=100, | ||
| title="Maximum confidence threshold: % confidence value starting from which to return 1 or -1." | ||
| ) |
There was a problem hiding this comment.
Shouldn't it be a min confidence value ?
| return self._get_signal_from_stored_signals(exchange, symbol, time_frame, version, candle_open_time) | ||
| if self.use_stored_signals_only(): | ||
| return await self._fetch_signal_from_stored_signals(exchange, symbol, time_frame, version, candle_open_time) | ||
| return await self._get_signal_from_gpt(messages, model, max_tokens, n, stop, temperature) |
Comment on lines
217
to
219
| def _get_open_candle_timestamp(self, time_frame: commons_enums.TimeFrames, base_timestamp: float): | ||
| tf_seconds = commons_enums.TimeFramesMinutes[time_frame] * commons_constants.MINUTE_TO_SECONDS | ||
| return base_timestamp - (base_timestamp % tf_seconds) |
There was a problem hiding this comment.
Don't we have already this code somewhere else?
GuillaumeDSM
changed the title
Herklos
approved these changes
Oct 27, 2023
Herklos
approved these changes
Oct 27, 2023
Herklos
reviewed
Oct 27, 2023
| @@ -55,7 +55,7 @@ def __init__(self, tentacles_setup_config): | |||
| self.indicator = None | |||
| self.source = None | |||
| self.period = None | |||
| self.min_confidence_threshold = 0 | |||
| self.min_confidence_threshold = 100 | |||
There was a problem hiding this comment.
yes, we don't want to round to 1 below 100% confidence by default
There was a problem hiding this comment.
I'm not sure I understand. I haven't seen any 100% confidence value sent by gpt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires Drakkar-Software/OctoBot#2450