[Webhook] Add custom domain support #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.webhook_server_context = self.webhook_app.app_context() | ||
| self.webhook_server_context.push() | ||
| except OSError as e: | ||
| self.webhook_server = None | ||
| self.logger.exception(e, False, f"Fail to start webhook : {e}") | ||
| self.get_logger().exception(e, False, f"Fail to start webhook : {e}") |
There was a problem hiding this comment.
why not self.logger here ?
There was a problem hiding this comment.
Hum that's not my changes, I have probably missed something
| @@ -155,17 +158,14 @@ def get_subscribe_url(self, service_feed_name): | |||
|
|
|||
| def _prepare_webhook_server(self): | |||
| try: | |||
| self.logger.debug(f"Starting local webhook server at {self.webhook_host}:{self.webhook_port}") | |||
Herklos
force-pushed
the
feature/add-ngrok-domain-support
branch
from
8220cb0 to
03911cd
Compare
|
Fixed |
GuillaumeDSM
approved these changes
Oct 11, 2023
Herklos
force-pushed
the
feature/add-ngrok-domain-support
branch
from
03911cd to
bb56690
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://feedback.octobot.online/open-source/p/add-support-for-ngrok-static-domains