Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DCA] fix time based DCA #1068

Merged
merged 2 commits into from
Oct 3, 2023
Merged

[DCA] fix time based DCA #1068

merged 2 commits into from
Oct 3, 2023

Conversation

GuillaumeDSM
Copy link
Member

No description provided.

@GuillaumeDSM GuillaumeDSM requested a review from Herklos October 3, 2023 09:41
@GuillaumeDSM GuillaumeDSM self-assigned this Oct 3, 2023
@GuillaumeDSM GuillaumeDSM enabled auto-merge (rebase) October 3, 2023 09:41
Herklos
Herklos reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@Herklos Herklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 Should we add a simple test on it ?

@GuillaumeDSM
Copy link
Member Author

😮 Should we add a simple test on it ?

Yes, good idea, i will !

@GuillaumeDSM
Copy link
Member Author

up

Herklos
Herklos approved these changes Oct 3, 2023
View reviewed changes
Trading/Mode/dca_trading_mode/tests/test_dca_trading_mode.py
dca_task_mock.assert_called_once()


async def test_dca_task(tools):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GuillaumeDSM GuillaumeDSM merged commit 701b26f into master Oct 3, 2023
@GuillaumeDSM GuillaumeDSM deleted the dca branch October 3, 2023 10:14
@GuillaumeDSM GuillaumeDSM restored the dca branch October 3, 2023 11:41
@GuillaumeDSM GuillaumeDSM deleted the dca branch October 3, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Herklos Herklos Herklos approved these changes

Assignees

@GuillaumeDSM GuillaumeDSM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuillaumeDSM @Herklos