[RemoteTradingSignalsModeConsumer] improve min funds handling

Drakkar-Software · Oct 12, 2023 · a9f19fe · a9f19fe
1 parent 5d7367d
commit a9f19fe
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/Trading/Mode/remote_trading_signals_trading_mode/remote_trading_signals_trading.py b/Trading/Mode/remote_trading_signals_trading_mode/remote_trading_signals_trading.py
@@ -163,8 +163,7 @@ async def internal_callback(self, trading_mode_name, cryptocurrency, symbol, tim
         try:
             await self._handle_signal_orders(symbol, data)
         except errors.MissingMinimalExchangeTradeVolume:
-            self.logger.info(f"Not enough funds to create a new order: {self.exchange_manager.exchange_name} "
-                             f"exchange minimal order volume has not been reached.")
+            self.logger.info(self.get_minimal_funds_error(symbol, final_note))
         except Exception as e:
             self.logger.exception(e, True, f"Error when handling remote signal orders: {e}")
 

diff --git a/...remote_trading_signals_trading_mode/tests/test_remote_trading_signals_trading_consumer.py b/...remote_trading_signals_trading_mode/tests/test_remote_trading_signals_trading_consumer.py
@@ -47,19 +47,19 @@ async def test_internal_callback(local_trader, mocked_sell_limit_signal):
     with mock.patch.object(consumer, "_handle_signal_orders",
                            new=mock.AsyncMock(side_effect=errors.MissingMinimalExchangeTradeVolume)) \
          as _handle_signal_orders_mock:
-        await consumer.internal_callback("trading_mode_name", "cryptocurrency", "symbol", "time_frame", "final_note",
+        await consumer.internal_callback("trading_mode_name", "cryptocurrency", "symbol/x", "time_frame", "final_note",
                                          "state", "data")
-        _handle_signal_orders_mock.assert_called_once_with("symbol", "data")
+        _handle_signal_orders_mock.assert_called_once_with("symbol/x", "data")
         consumer.logger.info.assert_called_once()
         consumer.logger.exception.assert_not_called()
         consumer.logger.info.reset_mock()
 
     with mock.patch.object(consumer, "_handle_signal_orders",
                            new=mock.AsyncMock(side_effect=RuntimeError)) \
          as _handle_signal_orders_mock:
-        await consumer.internal_callback("trading_mode_name", "cryptocurrency", "symbol", "time_frame", "final_note",
+        await consumer.internal_callback("trading_mode_name", "cryptocurrency", "symbol/x", "time_frame", "final_note",
                                          "state", "data")
-        _handle_signal_orders_mock.assert_called_once_with("symbol", "data")
+        _handle_signal_orders_mock.assert_called_once_with("symbol/x", "data")
         consumer.logger.info.assert_not_called()
         consumer.logger.exception.assert_called_once()