Drop ruby 2.5, support 3.2 and 3.3. Adjust dependencies, improve rubocop support and adjust CI on github. #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niezbop
approved these changes
Oct 29, 2024
lacostej
changed the title
lacostej
force-pushed
the
fix/build_github
branch
2 times, most recently
from
9ab509f to
662b0f4
Compare
lacostej
force-pushed
the
fix/build_github
branch
from
662b0f4 to
5ffc2fb
Compare
lacostej
changed the title
lacostej
changed the title
niezbop
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Pull Request Description
A bit more changes than I originally envisioned.
I had to enforce a set of deps compatible with 2.6 and 3.3, which bumped rubocop which caused some rules changes. I fixed the code instead of silencing the rules.
Most code changes made by rubocop were made automatically instead of those under lib/u3d/unity_module.rb (the
map.to_hto.to_hones.