Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve some code #115

Merged
merged 6 commits into from
Jul 20, 2024
Merged

Improve some code #115

merged 6 commits into from
Jul 20, 2024

Conversation

rneswold
Copy link
Contributor

Added several improvements:

  • In the logic block evaluator, the solar and time variables now restrict the second level field instead of using &str.
  • Updated the dependencies.
  • Remove compiler warnings from test code.

rneswold added 6 commits July 20, 2024 01:02
@rneswold
♻️ use an enum in TimeVal
3e84957 
Previously we were using a `str` which allowed any value to be in the
time field and required the code to validate it. Now it's an enum and
can only take on valid values.
@rneswold
♻️ create SolarField
0131105 
This changes the field of interest from a string to an enum.
@rneswold
🎨 format code
04efa40
@rneswold
📝 fix typo in comment
33eea78
@rneswold
🔧 fix compiler warnings
f5ad68c
@rneswold
⬆️ use latest crates
b584f74
@rneswold rneswold merged commit c2fd696 into DrMemCS:main Jul 20, 2024
4 checks passed
@rneswold rneswold deleted the pull-request branch July 20, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rneswold