Crazy Pulls #312
Open
Crazy Pulls #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stops sass from screaming about deprecated apis.
## About The Pull Request - Fixes tgstation#87235 Nested access levels after you unlock the crate for the 2nd time was too much even for the captain to deal with ## Changelog :cl: fix: personal ordered crates can be unlocked & relocked as many times again after the 1st attempt /:cl:
## About The Pull Request Closes tgstation#88592  ## Why It's Good For The Game Map consistency, bartenders need it to do their job ## Changelog :cl: map: Added a Condi-Master to Birdshot's bar /:cl:
…n#88598) ## About The Pull Request - Fixes tgstation#87829 Ensures we can't enter invalid values that actually run timed in this specific case ## Changelog :cl: fix: greyscale modify menu has better validation for player entered colours /:cl:
tgstation#88600) ## About The Pull Request You can now wear shoes with digitigrade legs thanks to tgstation#88096, but UI slots weren't informed of this change. ## Changelog :cl: fix: Fixed shoes slot being semi-transparent when you have digitigrade legs /:cl:
## About The Pull Request Nitroglycerin heals heart damage when metabolized ## Why It's Good For The Game - I thought it'd be a fun nod to one of the actual uses of Nitroglycerin. - "Plausible Deniability" to chemists making Nitroglycerin. - Adds more niche chem effects to the ecosystem chemists may experiment with. ## Changelog :cl: Melbert add: Nitroglycerin now heals heart damage. /:cl:
## About The Pull Request Teleporter code is at least +15 years old. This no longer applies. ## Why It's Good For The Game Accuracy. ## Changelog :cl: spellcheck: Update teleporter machine desc to be accurate /:cl:
## About The Pull Request - Fixes tgstation#88103 ## Changelog :cl: fix: fixed runtime when sealing mecha cabin with air tank installed /:cl:
## About The Pull Request There were two variables mixed up. It was `SEND_SOUND(holder, radio_noise)`, though it should be `SEND_SOUND(holder, radio_receive)`. Now everything is in place And also added `COOLDOWN_START(src, audio_cooldown, 0.5 SECONDS)` so that you don't hear two sounds at the same time when you talk into the radio <details> <summary>Screenshots/Videos</summary> https://github.com/user-attachments/assets/1afc1b36-4b6e-41d0-825d-aab6d9bdf694 </details> ## Why It's Good For The Game it's just a code issue ## Changelog :cl: fix: fix radio sound output when receiving a message sound: the sound of receiving your own messages over the radio is no longer played /:cl:
…gstation#88608) ## About The Pull Request - if an explosion epicenter is not on a station area, then it will not screen shake all mobs on the z level if it was really far ## Why It's Good For The Game - why should a bomb from 100 tiles away screenshake the entire z level? - players have brought up their annoyance with icebox gitbtonite shaking the entire z level every time one explodes. ## Changelog :cl: grungussuss del: screenshake from explosions will no longer happen when it's really far and not on a station area (turf) /:cl:
## About The Pull Request `5 SECONDS` instead of `50` ## Why It's Good For The Game Better code. ## Changelog :cl: code: Improved teleporter SECONDS defines /:cl:
## About The Pull Request
Apparently adding a tiny coffee machine worth of power to make this
accurate:
`to_chat(user, span_warning("You vastly increase projector power and
override the safety and security protocols."))`
was too much. So let's just do a grammar tweak to fix it.
Is
## Why It's Good For The Game
Accurate descriptions.
## Changelog
:cl:
spellcheck: Fix holodeck emag message claiming to increase power
/:cl:
## About The Pull Request This makes it so leeching walk and ascended rust heretic healing effects (the healing that occurs during life ticks) have the healing amount multiplied by `DELTA_WORLD_TIME(SSmobs)`, to compensate for skipped/delayed fires. ## Why It's Good For The Game Delays in SSmobs firing (i.e explosions pausing all non-ticker subsystems) can very easily get you killed if you're relying on the rust heretic healing mid-combat. ## Changelog :cl: qol: Rust heretic healing (leeching walk, rust ascension) now, so server lag shouldn't fuck you over nearly as much if you're relying on the healing. /:cl:
…ow!" (tgstation#88610) ## About The Pull Request Made bioscrabmle() proc's armor check silent and moved text from a successful block into its early return. ## Why It's Good For The Game Less than 100 protection from bioscramblers doesn't do anything, so text about "armor softening the blow" is nonsensical, both as there is no blow to soften, and as armor below 100 doesn't actually do anything. A bit of a nitpick, but its been annoying me to all hell every time I encounter one (as RD's coat provides some protection). Only other source of BIO armor checks is Phazon, but the text makes sense there and nothing runs armor checks against FIRE and ACID, so there's nothing else to fix. ## Changelog :cl: spellcheck: Bioscrambler no longer informs you about "your armor softening the blow!" /:cl:
… custom amount (tgstation#88590) ## About The Pull Request tgstation#82002 changed custom transfer amount into a TGUI popup, which has rounding on by default. This prevents players from being able to transfer decimal amounts of reagents like they could previously. ## Why It's Good For The Game This is useful for high-purity recipes, or when you REALLY want to microdose something. Right now the only way to do this is by printing tiny pills and dissolving those which is very bootleg. ## Changelog :cl: fix: Chemmaster no longer rounds reagent amounts when trying to transfer a custom amount /:cl:
## About The Pull Request **1. Code Improvements** - Converted `rcd_range` from a var into a define to save memory - Removed var `rcd_type` as it was redundant with the type of `internal_rcd` var - Moved attack chain code from `attackby()` to `interact_with_atom()` when installing disk upgrade **2. Fixes** Fixes tgstation#88589 (comment), tgstation#88589 (comment). i.e. the RCD cancels it's construction & deconstruction action if - The mech rotates away from where its building - The mech moves ## Changelog :cl: code: improved code for mecha rcd fix: mecha rcd will cancel its action when the mech is rotated or moves during the action /:cl:
## About The Pull Request Fixes lead acid battery being overlooked in the split between cell and megacell. It still remains a very good battery fitting of being rare maintenance loot, but it's no longer equivalent to several bluespace cells combined. It is a cell with a maximum charge of 600kJ, more than a bluespace cell, but a lower charge rate and no charge indicator. It spawns with 250kJ to 350kJ in starting charge, between super and hyper. ## Why It's Good For The Game Fixes tgstation#88573 ## Changelog :cl: LT3 fix: Fixed lead acid cell having extremely high max charge /:cl:
…ted objects (tgstation#88745) ## About The Pull Request Closes tgstation#88644 Insanity ## Changelog :cl: fix: Fixed chair, echair, wheelchair and vehicle overlays on painted objects /:cl:
## About The Pull Request Closes tgstation#88655 ## Changelog :cl: fix: Fixed podperson hair not updating /:cl:
## About The Pull Request - Fixes tgstation#88727 Now when an atom shatters if that turf is blocked by a dense object (e.g. wall, closed airlock, window etc) such that no air can pass through it then we drop stuff on the thrown object's location and not on the hit target location. In laymen's terms if you throw a plate on the wall, window, closed airlock etc then the shattered contents drop on the plate's last location & not on the wall itself ## Changelog :cl: fix: Fixes shattering element dropping stuff on blocked turfs /:cl:
…gstation#88754) ## About The Pull Request closes tgstation#88743 . the issue is while they'd ignore ur command since its impossible, the emote would still appear, which i now realize was a mistake ## Why It's Good For The Game fixes being able to tell animals to commit atrocious acts ## Changelog :cl: fix: radial pet commanding emotes will now not appear if the command is impossible to execute /:cl:
This pull request updates the TGS DMAPI to the latest version. Please note any changes that may be breaking or unimplemented in your codebase by checking what changes are in the definitions file: code/__DEFINES/tgs.dm before merging. Full changelog can be found [here](https://raw.githubusercontent.com/tgstation/tgstation-server/gh-pages/changelog.yml). - Added compatibility with SpacemanDMM's `redefined_proc` lint. (tgstation#2058 Cyberboss) #tgs-dmapi-release Co-authored-by: tgstation-ci[bot] <179393467+tgstation-ci[bot]@users.noreply.github.com> Co-authored-by: LemonInTheDark <[email protected]>
…gstation#88636) ## About The Pull Request you can adjust diagonal walls to not diagonal walls with a wrench https://github.com/user-attachments/assets/0a708b7d-195b-41ad-b7f4-cf9f8142e730 ## Why It's Good For The Game when youre building the shuttle you literally always forget to put tiles under diagonal titanium walls so you just have plating there this is fixed by letting players not make it diagonal ## Changelog :cl: qol: you can adjust diagonal walls to be not diagonal walls with a wrench /:cl:
## About The Pull Request - added a signal - `COMSIG_ATOM_DENSITY_CHANGED`, is sent when set_density is called and doesn't early return - changed all manual assignments of .density to use `set_density` so the signal is sent - airlocks get the leanable component, if the airlock opens while you are leaning on it - you will fall - computers get the leanable component ## Why It's Good For The Game can lean on more stuff, roleplay! Immersion! *John Tider leans on the airlock* ## Changelog :cl: grungussuss add: computers and airlocks are now leanable refactor: changed how density/collision of some objects is changed, report any oddities! /:cl: --------- Co-authored-by: SyncIt21 <[email protected]>
… copying them to the copy (tgstation#88764) ## About The Pull Request Photocopiers were trying to copy the stamp overlays from the new blank paper onto the original, and cutting the original's old overlays in the process. This inverts that statement and removes the cutting part. ## Why It's Good For The Game Nice if photocopying doesn't remove the stamp overlays on the original just cause it feels like it. ## Changelog :cl: fix: Photocopying no longer removes the stamp overlays from the original paper, and actually copies them to the copy. /:cl:
…their deactivated core is destroyed (tgstation#88528)
Paxilmaniac
requested review from
carpotoxin,
Ephemeralis and
kannthus
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Why It's Good For The Game
You can successfully make rice bread now.